From 8326bacdbbeebbbe3619c5a039653754c2cd0e61 Mon Sep 17 00:00:00 2001 From: Robert Choi Date: Tue, 7 May 2024 11:44:01 +0900 Subject: [PATCH] bugfix: disable rollback of latest task --- internal/delivery/http/app-serve-app.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/internal/delivery/http/app-serve-app.go b/internal/delivery/http/app-serve-app.go index 70a383ac..5a76487e 100644 --- a/internal/delivery/http/app-serve-app.go +++ b/internal/delivery/http/app-serve-app.go @@ -574,8 +574,16 @@ func (h *AppServeAppHandler) GetAppServeAppTaskDetail(w http.ResponseWriter, r * return } - // TODO: this should be false for latest task - if strings.Contains(task.Status, "SUCCESS") && task.Status != "ABORT_SUCCESS" && + // Workaround: Compare task ID with latest task ID + // Mark latest task with additional flag later + latestTask, err := h.usecase.GetAppServeAppLatestTask(r.Context(), appId) + if err != nil { + ErrorJSON(w, r, httpErrors.NewInternalServerError(err, "", "")) + return + } + if taskId == latestTask.ID { + task.AvailableRollback = false + } else if strings.Contains(task.Status, "SUCCESS") && task.Status != "ABORT_SUCCESS" && task.Status != "ROLLBACK_SUCCESS" { task.AvailableRollback = true }