Generalize W3C Digital Credentials API references #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leecam
reviewed
Nov 20, 2024
timcappalli
changed the title
Sakurann
requested review from
danielfett,
jogu,
samuelgoto,
marcoscaceres,
c2bo,
tplooker,
paulbastian,
awoie,
martijnharing and
bc-pi
Sakurann
reviewed
Nov 21, 2024
Sakurann
reviewed
Nov 21, 2024
Sakurann
approved these changes
Nov 21, 2024
c2bo
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Not entirely sure what the best approach for the origin is, but given that webauthn already uses one origin parameter for browser-initiated or native app calls, it feels like that would be the logical way to go as well?
Looks good to me once the origin discussion is resolved.
Co-authored-by: Christian Bormann <[email protected]>
Co-authored-by: Kristina <[email protected]>
leecam
approved these changes
Nov 28, 2024
tlodderstedt
approved these changes
Nov 28, 2024
danielfett
approved these changes
Nov 28, 2024
jogu
added a commit
that referenced
this pull request
Nov 30, 2024
The response_mode needs to be updated as per #337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion on yesterday's call, this changes the following:
response_modetodc_api