Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI percent-encoding in examples #319

Closed
c2bo opened this issue Nov 12, 2024 · 1 comment · Fixed by #323
Closed

URI percent-encoding in examples #319

c2bo opened this issue Nov 12, 2024 · 1 comment · Fixed by #323

Comments

@c2bo
Copy link
Member

c2bo commented Nov 12, 2024

We have several examples that contain a client_id with the new client_id_scheme prefixing in URIs like this:

GET /authorize?
  response_type=vp_token
  &client_id=redirect_uri:https%3A%2F%2Fclient.example.org%2Fcb
  &redirect_uri=https%3A%2F%2Fclient.example.org%2Fcb
  &presentation_definition=...
  &transaction_data=...
  &nonce=n-0S6_WzA2Mj HTTP/1.1

Shouldn't the client_id line be this?
&client_id=redirect_uri%3Ahttps%3A%2F%2Fclient.example.org%2Fcb

Similarly, the example in 5.10.4 contains : inside the client_metadata

 &client_metadata=%7B%22vp_formats%22:%7B%22jwt_vp_json%22:%
  7B%22alg%22:%5B%22EdDSA%22,%22ES256K%22%5D%7D,%22ldp
  _vp%22:%7B%22proof_type%22:%5B%22Ed25519Signature201
  8%22%5D%7D%7D%7D

and should be this unless I am mistaken?

&client_metadata=%7B%22vp_formats%22%3A%7B%22jwt_vp_json%2
2%3A%7B%22alg%22%3A%5B%22EdDSA%22%2C%22ES256K%22%5
D%7D%2C%22ldp_vp%22%3A%7B%22proof_type%22%3A%5B%22Ed
25519Signature2018%22%5D%7D%7D%7D
@danielfett
Copy link
Contributor

This is correct and probably my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants