Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefersEphemeralSession parameter for external user-agents #645

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Add prefersEphemeralSession parameter for external user-agents #645

merged 5 commits into from
Aug 19, 2022

Conversation

danblakemore
Copy link
Collaborator

@danblakemore danblakemore commented Jun 23, 2021 •
edited by petea
Loading

Adds BOOL parameters to external user-agent methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.

@danblakemore
Add emphemeral browser option iOS/Catalyst user agents.
7642d9d 
Adds BOOL properties to iOS/Catalyst-related methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.
@sgrgrsn
Copy link

sgrgrsn commented Nov 10, 2021

This would be really useful to have so we don't have to set up a custom user agent. What's the process of getting a PR like this merged?

@Econa77 Econa77 mentioned this pull request Feb 16, 2022
Merged
@petea petea changed the title Add emphemeral browser option iOS/Catalyst user agents. Add ephemeral browser option iOS/Catalyst user agents. Aug 16, 2022
@petea
Copy link
Collaborator

petea commented Aug 16, 2022

@danblakemore since you sent this PR, we've added ASWebAuthenticationSession support to OIDExternalUserAgentMac with #675. For consistency, would you be willing to extend your approach here to this macOS implementation of OIDExternalUserAgent as well? Implementation should be very similar to the iOS case.

This was referenced Aug 16, 2022
Closed
Closed
@petea petea added this to the 1.6.0 milestone Aug 16, 2022
@danblakemore
Copy link
Collaborator Author

Yep, I can send a new one shortly.

@amritnew
Copy link

Is there any timeline for this PR to be merged?

@danblakemore
Add emphemeral browser option to macOS user agent.
8f51dcd 
Adds BOOL arguments to macOS-related methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.
@danblakemore
Copy link
Collaborator Author

Let me know if there's additional changes required for this PR.

@petea petea changed the title Add ephemeral browser option iOS/Catalyst user agents. Add prefersEphemeralSession parameter for external user-agents Aug 17, 2022
petea
petea reviewed Aug 17, 2022
View reviewed changes
@danblakemore
Update doc comments based on review feedback.
811db75 
Also fixes some formatting and code symbol annotation to support Xcode Quick Help.
danblakemore
danblakemore commented Aug 17, 2022
View reviewed changes
Copy link
Collaborator Author

@danblakemore danblakemore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a new commit with changes addressing these comments.

petea
petea approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@petea petea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@danblakemore danblakemore merged commit c1a5080 into openid:master Aug 19, 2022
@Tijijoy1989
Copy link

Dear Team,
Thanks a lot for solving the logout issue.
With this prefersEphemeralSession parameter for external user-agents we are able to do a proper logout of our users in our IOS application. We need to release our app in September. @danblakemore when can we expect the next release of AppAuth pod with this change?

@paritosh-yadav paritosh-yadav mentioned this pull request Aug 23, 2022
Closed
@petea petea mentioned this pull request Aug 23, 2022
Open
@diegoventura
Copy link

@petea any timeline for the next release?

@petea
Copy link
Collaborator

petea commented Aug 30, 2022

Hoping to have 1.6.0 out sometime next week.

@j-petty j-petty mentioned this pull request Sep 1, 2022
Closed
@danblakemore danblakemore deleted the ephemeral branch September 6, 2022 15:48
eigentone11 added a commit to eigentone11/AppAuth-iOS that referenced this pull request Sep 13, 2022
@eigentone11
Merge commit '74239430b5219ba502d34349288cd27db010eca2'
f821b2f 
* commit '74239430b5219ba502d34349288cd27db010eca2':
  Update issue templates (openid#723)
  Prep for 1.6.0 release (openid#722)
  Correct OIDServiceDiscovery's NSCoding implementation (openid#721)
  Update OIDServiceConfiguration.m (openid#656)
  Add prefersEphemeralSession parameter for external user-agents (openid#645)
  Update ObjC style guide link.

# Conflicts:
#	UnitTests/OIDServiceDiscoveryTests.m
eigentone11 added a commit to eigentone11/AppAuth-iOS that referenced this pull request Sep 13, 2022
@eigentone11
Merge branch 'master' into backend-auth
be77aa1 
* master:
  update deployment target
  Update issue templates (openid#723)
  Prep for 1.6.0 release (openid#722)
  Correct OIDServiceDiscovery's NSCoding implementation (openid#721)
  Update OIDServiceConfiguration.m (openid#656)
  Add prefersEphemeralSession parameter for external user-agents (openid#645)
  Update ObjC style guide link.
tonyphn pushed a commit to brighthr/AppAuth-iOS that referenced this pull request Feb 2, 2023
@danblakemore @tonyphanbhr
Add prefersEphemeralSession parameter for external user-agents (openi…
ded4327 
…d#645)

* Add emphemeral browser option iOS/Catalyst user agents.

Adds BOOL properties to iOS/Catalyst-related methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.

* Add emphemeral browser option to macOS user agent.

Adds BOOL arguments to macOS-related methods which allow setting the ASWebAuthenticationSession property prefersEphemeralWebBrowserSession.

* Update doc comments based on review feedback.

Also fixes some formatting and code symbol annotation to support Xcode Quick Help.

* Replace 'Catalyst' with 'external' in method brief
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petea petea petea approved these changes

@PierreEc PierreEc PierreEc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@danblakemore @sgrgrsn @petea @amritnew @Tijijoy1989 @diegoventura @PierreEc