Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow request handler to stop listening for a response #89

Open
cjgarland opened this issue Oct 29, 2018 · 2 comments
Open

Allow request handler to stop listening for a response #89

cjgarland opened this issue Oct 29, 2018 · 2 comments
Assignees

Comments

@cjgarland
Copy link

Expected Behavior

It would be useful if there was a method on the NodeBasedHandler to stop waiting for a response / close the server if the auth redirect flow is interrupted or cancellation request is issued

Describe the problem

If a user interrupts the auth redirect flow (closing the browser or navigating away, for example) then the authorization request never completes and the server remains waiting for a response.

Actual Behavior

There is no way to close the server

Steps to reproduce the behavior

Initiate the auth redirect, then close the browser without completing the process.

Environment

  • AppAuth-JS version: 0.3.5
  • AppAuth-JS Environment (Node, Browser (UserAgent), ...): Node
@tikurahul
Copy link
Collaborator

This is a valid feature request. I will add this to my backlog. You should take a look at node_support/node_request_handler.ts to enable this on your own in the meantime.

@jmaha
Copy link

jmaha commented Jun 15, 2023

This bit us as well. It would be nice if there was a function call to abort an existing request as all the members that could allow us to do so are marked protected and inaccessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants