Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding esphome dashboard install and uninstall feature #1932

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

miloit
Copy link

@miloit miloit commented Dec 15, 2024

Description:

This pull request adds the ESPHome dashboard installation and uninstallation feature to the OpenHABian setup. The feature allows users to easily install or uninstall the ESPHome dashboard as part of the OpenHABian configuration process.

Changes:

Added a new option to the OpenHABian configuration menu to install the ESPHome dashboard.
Implemented the ability to uninstall the ESPHome dashboard from the system.
Updated related documentation for the new feature.
Why this is needed:
This update provides users with a streamlined way to manage the ESPHome dashboard directly from the OpenHABian setup, improving the ease of use and flexibility for those integrating ESPHome with OpenHAB.

Closes Issue:

Resolves #1904.

Copy link
Contributor

@ecdye ecdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, implement the changes suggested here, and double check and compare your code to the other install sequences in the codebase and that should get you most of the rest of the way there.

Also take a look at the error message for DSC Bot on how to properly sign off your commits.

Let me know if you have any questions.

functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
functions/packages.bash Outdated Show resolved Hide resolved
@miloit miloit force-pushed the esphomedashboardinstall branch from 7e7c7f9 to 9e2c6d3 Compare December 16, 2024 11:59
@miloit
Copy link
Author

miloit commented Dec 16, 2024

@ecdye Can you help me with signing off

Commit sha: [6598f36]
Commit sha: [4a53434]
Commit sha: [136f2a7]
Commit sha: [d1077d8]

@ecdye
Copy link
Contributor

ecdye commented Dec 17, 2024

@ecdye Can you help me with signing off

Commit sha: [6598f36] Commit sha: [4a53434] Commit sha: [136f2a7] Commit sha: [d1077d8]

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

You are the only author of the commits in this branch
You are absolutely certain nobody else is doing any work based upon this branch
There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)
To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~7 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin esphomedashboardinstall

Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
@miloit miloit force-pushed the esphomedashboardinstall branch from 9e2c6d3 to 8e11f96 Compare December 18, 2024 06:13
Signed-off-by: michaelloercher <[email protected]>
@miloit miloit requested a review from ecdye December 18, 2024 21:51
Signed-off-by: michaelloercher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Optional Components] ESPhome dashboard
2 participants