Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Adding some measurement extensions : RF Status, Wifi Status, Battery Lev... #1551

Merged
merged 4 commits into from
Nov 5, 2014
Merged

Adding some measurement extensions : RF Status, Wifi Status, Battery Lev... #1551

merged 4 commits into from
Nov 5, 2014

Conversation

clinique
Copy link
Contributor

...el, Altitude, Latitude, Longitude.

Fills Netatmo Enhancement requested in issue #1420

@buildhive
Copy link

openhab » openhab #1375 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

openhab » openhab #1384 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

@buildhive
Copy link

openhab » openhab #1385 SUCCESS
This pull request looks good
(what's this?)

@clinique
Copy link
Contributor Author

@abrenk to review if it feel like it's first idea

@@ -0,0 +1,36 @@
package org.openhab.binding.netatmo.internal;
import org.apache.commons.lang.StringUtils;
public enum NetatmoMeasureType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add javadoc on class level containing @SInCE and @author and some description what this class is about

@teichsta
Copy link
Member

Hi @clinique, thanks for this contribution, please my comments inline. Best, Thomas E.-E.

@buildhive
Copy link

openhab » openhab #1395 SUCCESS
This pull request looks good
(what's this?)

teichsta added a commit that referenced this pull request Nov 5, 2014
[Netatmo] Adding some measurement extensions : RF Status, Wifi Status, Battery Lev...
@teichsta teichsta merged commit 5645b6a into openhab:master Nov 5, 2014
@clinique clinique deleted the netatmoextension branch November 6, 2014 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants