This repository has been archived by the owner on May 17, 2021. It is now read-only.
Squeezebox Binding: Sync "remove" players incorrect #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sync:XXX" binding command for multi-player playback sync & its respective OFF command is incorrect. It's removing the source player and not the target player. As the LMS "sync -" CLI command only supports a single playerID then it should be the target synced player and not the source one. Also means that when re-adding another player into another player group the OFF command will always remove the correct respective player.
|
openhab » openhab #1225 SUCCESS |
|
openhab » openhab #1226 SUCCESS |
|
openhab » openhab #1227 SUCCESS |
teichsta
added a commit
that referenced
this pull request
Sep 23, 2014
Squeezebox Binding: Sync "remove" players incorrect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "sync:XXX" binding command for multi-player playback sync & its
respective OFF command is incorrect. It's removing the source player and
not the target player.
As the LMS "sync -" CLI command only supports a single playerID then it
should be the target synced player and not the source one.
Also means that when re-adding another player into another player group
the OFF command will always remove the correct respective player.