Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap editor: Add support for color temperature picker #2880

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Nov 18, 2024

Closes #2852.

Refs openhab/openhab-core#4420.
Related to openhab/openhab-core#3891.

This PR implements configuring a color temperature picker in the sitemap builder UI.

It also does some visualisation improvements of names and labels (by defaults shows item label in treeview, analogous to model treeview).

Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
Copy link

relativeci bot commented Nov 18, 2024

#2504 Bundle Size — 10.87MiB (+0.02%).

1dab231(current) vs b06c21f main#2502(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2504
     Baseline
#2502
Regression  Initial JS 1.91MiB(+0.34%) 1.91MiB
Regression  Initial CSS 577.48KiB(+0.03%) 577.31KiB
Change  Cache Invalidation 22.99% 17.55%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2942(+0.07%) 2940
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2504
     Baseline
#2502
Regression  JS 9.08MiB (+0.02%) 9.08MiB
Regression  CSS 864.45KiB (+0.05%) 864KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:colortemperaturepickerProject dashboard


Generated by RelativeCIDocumentationReport issue

Signed-off-by: Mark Herwege <[email protected]>
@florian-h05
Copy link
Contributor

@mherwege FYI I will try to review this the next days before the next milestone, would be too bad to not have it in 4.3.

@florian-h05 florian-h05 added this to the 4.3 milestone Nov 30, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 30, 2024
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Nice refactoring with the mixin.

I found two bugs I fixed myself, you can have a look at my two individual commits.

@florian-h05 florian-h05 changed the title Sitemap editor: implement color temperature picker Sitemap editor: Add support for color temperature picker Nov 30, 2024
@florian-h05 florian-h05 merged commit 09b153c into openhab:main Nov 30, 2024
8 checks passed
@mherwege mherwege deleted the colortemperaturepicker branch November 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Colortemperaturepicker in sitemap builder
2 participants