-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BasicUI] Add preview color to Colorpicker widget #2873
Conversation
Also clenup class ColorpickerRenderer Signed-off-by: Laurent Garnier <[email protected]>
Why would we need the palette button here at all? It would feel more natural to me that I click on the colored circle if I want to change the color... |
I was not sure but it was also what I was thinking ;) Do you think I should just keep the new circle or rather keep only the rectangle button but with the current color inside and no icon ? |
Agreed. Having a look at it, I would actually say the same there: The picker button is redundant if the user could simply click on the colored circle.
I don't have a strong opinion. The circle already "invites" the user to click on it, but we could also stick to the rectagular look of the buttons - this might be the more consistent option. |
Do it also for the Colortemperaturepicker widget Signed-off-by: Laurent Garnier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, I like it!
Thanks. 😄
Also include a small change of the Colorpicker element. Related to openhab/openha-core#3891 Related to openhab/openhab-webui#2873 Signed-off-by: Laurent Garnier <[email protected]>
Also include a small change of the Colorpicker element. Related to openhab/openhab-core#3891 Related to openhab/openhab-webui#2873 Signed-off-by: Laurent Garnier <[email protected]>
* [sitemap] New Colortemperaturepicker element Also include a small change of the Colorpicker element. Related to openhab/openhab-core#3891 Related to openhab/openhab-webui#2873 Signed-off-by: Laurent Garnier <[email protected]> * Review comments Signed-off-by: Laurent Garnier <[email protected]> --------- Signed-off-by: Laurent Garnier <[email protected]>
This looks very nice, thank you very much @lolodomo! Maybe we can built something like this for the other clients, looking at the android app @mueller-ma ? That's be great |
I'm pretty sure that there was a preview like this when I merged @maniac103 PR that implements this new widget. |
Yes, the Android app does it like that already [1] (displaying the color preview instead of the palette), with one tweak: if the light is off (brightness = 0) or the state is unknown, the palette is shown instead of the preview because a black preview looks somewhat ugly. [1] In the beta, I did this for consistency when implementing the color temperature picker widget. |
Also clenup class ColorpickerRenderer