You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sitemap pagedesigner widget uses wrong type number for control Separator. Therefore a correct separator for a list widget (like ,) cannot be set via the designer. It is possible to set the separator via code (see screenshot below) but the set separator will not be displayed in the designer (and a following change+save of the separator with a string/text in the designer results in an unset of the seperator in the sitemap code... i guess because of validation?).
Expected behavior
Control separator should have type text so it is possible to set the separator with the designer too.
Steps to reproduce
make a sitemap (Settings -> Pages -> Create Sitemap)
add a list widget
try to set separator , in designer
save the sitemap (no error occures and separator is still visible in designer)
switch to tab Code
no separator prop was added in sitemap code
switch back to tab Design
separator , disappeared
Your environment
runtimeInfo:
version: 3.1.0buildString: "Build #2211"locale: de-ATsystemInfo:
configFolder: c:\openhab\confuserdataFolder: c:\openhab\userdatalogFolder: c:\openhab\userdata\logsjavaVersion: 11.0.6javaVendor: Oracle CorporationjavaVendorVersion: "18.9"osName: Windows 10clientInfo:
device:
firefox: trueos: windows
The problem
Sitemap pagedesigner widget uses wrong type
number
for controlSeparator
. Therefore a correct separator for a list widget (like,
) cannot be set via the designer. It is possible to set the separator via code (see screenshot below) but the set separator will not be displayed in the designer (and a following change+save of the separator with a string/text in the designer results in an unset of the seperator in the sitemap code... i guess because of validation?).Expected behavior
Control
separator
should have typetext
so it is possible to set the separator with the designer too.Steps to reproduce
,
in designerCode
Design
,
disappearedYour environment
Additional information
The problem seems to be in this line:
openhab-webui/bundles/org.openhab.ui/web/src/components/pagedesigner/sitemap/widget-details.vue
Line 30 in eb7596c
ListRenderer in BasicUI uses
getSeparator()
to split the stringopenhab-webui/bundles/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/ListRenderer.java
Line 64 in eb7596c
and according to
openhab-core
separator is of typestring
:https://github.com/openhab/openhab-core/blob/4a79e9bfe7dca9f6abd1e40d3eb398a9aa2c8988/bundles/org.openhab.core.model.sitemap/src/org/openhab/core/model/sitemap/Sitemap.xtext#L104
I'm willing to submit a PR that fixes the wrong type in the
widget-details.vue
file.The text was updated successfully, but these errors were encountered: