-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parameter in actions.notificationBuilder() optional #368
Comments
I discovered that the parameter is actually optional. When using it without a parameter, it crashes the Android app, but that's a different issue (openhab/openhab-android#3794). |
It was actually not planned that this is supported, rather works by coincidence. But I think it would be better to pass an empty string, WDYT? |
See #370. |
Yes, because that will also work with all clients. |
Most of my notifications only contain a title as IMO it looks better on Android to have a title than a message. Thus most times I pass an empty string to
actions.notificationBuilder("")
. Maybe this parameter could be made optional with""
as default value.The text was updated successfully, but these errors were encountered: