Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toplevel folder to distribution zip #1262

Open
weberjn opened this issue Feb 14, 2021 · 1 comment
Open

add toplevel folder to distribution zip #1262

weberjn opened this issue Feb 14, 2021 · 1 comment

Comments

@weberjn
Copy link

weberjn commented Feb 14, 2021

If the openhab.zip would contain a toplevel folder, you'd just have to unzip it and be ready to go. Some beginners might not know unzip -d ..

In Maven speak this would be convention over configuration, as most open source software zips do contain a toplevel folder, e.g. Apache Tomcat, Wildfly or Eclipse.

In the Tomcat way, for openhab-3.0.1.zip the toplevel folder should be openhab-3.0.1

As for the pros who want a different folder name, they certainly know how to rename it.

@wborn
Copy link
Member

wborn commented Apr 27, 2022

In the Tomcat way, for openhab-3.0.1.zip the toplevel folder should be openhab-3.0.1

It will probably cause issues when updating the version number of an existing instance after an upgrade, see #860.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants