Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation] Scripts should be unloaded when the ScriptEngineFactory becomes unavailable #2458

Closed
J-N-K opened this issue Aug 17, 2021 · 0 comments · Fixed by #2459
Closed

[automation] Scripts should be unloaded when the ScriptEngineFactory becomes unavailable #2458

J-N-K opened this issue Aug 17, 2021 · 0 comments · Fixed by #2459

Comments

@J-N-K
Copy link
Member

J-N-K commented Aug 17, 2021

Currently scripts are loaded on startup or when they are modified or newly created on runtime. If no corresponding ScriptEngineFactory is available they are queued and retried later when a ScriptEngineFactory is added. This works quite good. The other way is not working at all. Scripts stay in memory when the corresponding ScriptEngineFactory becomes unavailable. IMO they should be unloaded in that case.

The implementation could be an extension to the DependencyTracker (which currently only tracks dependencies on libraries).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[automation] implement a listener for ScriptEngineFactory changes J-N-K/openhab-core
1 participant
@J-N-K