Include the name of the Item in warning logs from ItemStateConditionHandler

[rkoshak]

I just spent a little bit of time hunting down the cause of a warning from org.openhab.core.automation.internal.module.handler.ItemStateConditionHandler and I'm sure I'm not the only one. The log in my case was:

Received a QuantityType state '75 %' with unit, but the condition is defined as a plain number without unit (50), please consider adding a unit to the condition.

Line 112 in the .java file.

That's really a great log message except it's missing the one key piece of information I as the user need: the name of the Item.

There are other log statements in this file that could benefit from the inclusion of the Item name as well.

• Line 120
• Line 138
• Line 146
• Line 163
• Line 171
• Line 189
• Line 197

I'd make the changes myself but I don't have a build environment and it'd take me a bit to set one up. I'm hesitant to blindly submit even such a simple change as this without being able to build and test.

Thanks!

[J-N-K]

IMO it would be better to log the ruleUID of the rule that this condition belongs to.

[rkoshak]

From looking at the code I don't see that the rule ID is currently available in that class. But the Item name is definitely available. If getting both is possible that would be the best.

[cweitkamp]

I submitted #2540 to improve the logging.