Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networkupstools] Incorrectly uses ups.temperature #15606

Closed
utdrmac opened this issue Sep 16, 2023 · 2 comments · Fixed by #15812
Closed

[networkupstools] Incorrectly uses ups.temperature #15606

utdrmac opened this issue Sep 16, 2023 · 2 comments · Fixed by #15812
Assignees
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@utdrmac
Copy link

utdrmac commented Sep 16, 2023

UPS_TEMPERATURE("upsTemperature", "ups.temperature", SIUnits.CELSIUS),

The NUT binding incorrectly uses ups.temperature when it should be battery.temperature.

$ telnet 127.0.0.1 3493
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
LIST UPS
BEGIN LIST UPS
UPS tripplite "Description unavailable"
END LIST UPS
LIST VAR tripplite
BEGIN LIST VAR tripplite
VAR tripplite battery.charge "100"
VAR tripplite battery.charge.low "10"
VAR tripplite battery.charge.warning "30"
VAR tripplite battery.runtime "1540"
VAR tripplite battery.temperature "41.9"
VAR tripplite battery.type "PbAC"
VAR tripplite battery.voltage "40.9"
VAR tripplite battery.voltage.nominal "36.0"
VAR tripplite device.mfr "Tripp Lite "
VAR tripplite device.model "TRIPP LITE SMART1500RM2UN "
VAR tripplite device.serial "2424AY0SM882300005"
VAR tripplite device.type "ups"
VAR tripplite driver.name "usbhid-ups"
VAR tripplite driver.parameter.pollfreq "30"
VAR tripplite driver.parameter.pollinterval "2"
VAR tripplite driver.parameter.port "auto"
VAR tripplite driver.parameter.synchronous "no"
VAR tripplite driver.parameter.vendorid "09ae"
VAR tripplite driver.version "2.7.4"
VAR tripplite driver.version.data "TrippLite HID 0.82"
VAR tripplite driver.version.internal "0.41"
VAR tripplite input.frequency "59.8"
VAR tripplite input.transfer.high "0.0"
VAR tripplite input.transfer.low "0.0"
VAR tripplite input.voltage "119.3"
VAR tripplite input.voltage.nominal "120"
VAR tripplite output.current "2.0"
VAR tripplite output.frequency "59.8"
VAR tripplite output.frequency.nominal "60"
VAR tripplite output.voltage "0.0"
VAR tripplite output.voltage.nominal "120"
VAR tripplite ups.beeper.status "enabled"
VAR tripplite ups.delay.shutdown "20"
VAR tripplite ups.delay.start "30"
VAR tripplite ups.load "23"
VAR tripplite ups.mfr "Tripp Lite "
VAR tripplite ups.model "TRIPP LITE SMART1500RM2UN "
VAR tripplite ups.power "0.0"
VAR tripplite ups.power.nominal "1500"
VAR tripplite ups.productid "3015"
VAR tripplite ups.serial "2424AY0SM882300005"
VAR tripplite ups.status "OL"
VAR tripplite ups.test.result "Done and passed"
VAR tripplite ups.timer.reboot "-1"
VAR tripplite ups.timer.shutdown "-1"
VAR tripplite ups.timer.start "-1"
VAR tripplite ups.vendorid "09ae"
VAR tripplite ups.watchdog.status "0"
END LIST VAR tripplite
^]close

telnet> close
Connection closed.

Possible Solution

Some UPS units may report ups.temperature but others might report battery.temperature like mine does. Add both?

Context

Since this binding is using the wrong parameter, the values for temperature are UNDEF

Your Environment

  • Version used: 3.4.4
@utdrmac utdrmac added the bug An unexpected problem or unintended behavior of an add-on label Sep 16, 2023
@lsiepel lsiepel changed the title NUT Binding Incorrectly uses ups.temperature [networkupstools] Incorrectly uses ups.temperature Sep 16, 2023
@lsiepel
Copy link
Contributor

lsiepel commented Sep 16, 2023

If you update to openHAB 4.1 M1 you can test this jar. It has the channel added. When you use managed config: please do not remove the thing, just disable the curent binding and drop this jar in your addon folder.
This way you also test the upgrade instructions. xml and the channel should be added automatically.

Test jar 4.1.0 M1 :"https://1drv.ms/u/s!AnMcxmvEeupwjtdFwfPTf7eU_2qN1g?e=NQqxcD
Source here: lsiepel@3c81e2a

Please let me know your test results.

@lsiepel lsiepel self-assigned this Sep 16, 2023
@lsiepel
Copy link
Contributor

lsiepel commented Oct 20, 2023

@utdrmac gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants