-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS Scripting (Nashorn) addon to addons #14005
Comments
PR to add the JS Scripting (Nashorn) engine to the addons repository is now open: #14013. |
I'd agree with this plan only if we have some sort of upgrade automation to go fix everyone's rules to use the swapped MIME type. I believe it was always the intent to give the official MIME to GraalVM JS at this point but it's going to break a lot of people's systems if we don't help them. I just tried the 4.0 snapshot and it didn't go well on that front. Note: the only way to change the MIME type in a Script (i.e. stuff under Scripts in MainUI) is through the REST API or editing the JSONDB file manually. We must avoid that if at all possible. Assuming Blockly is ported, I have no worries about not including Nashorn by default. Moving to a new version is the time to break all the things! But we need to help clean up where we can. |
Yes, we need a easy to use option in the UI for that. Probably we should also have an option to regenerate all Blockly scripts at once, so that the user doesn't have to open each Blockly and click the save button. That is definitely something the UI needs to do. |
When openHAB 4.0 switches to Java 17, NashornJS will be removed from core.
We should then add the JS Scripting (Nashorn) automation addon to the addons repository.
We should discuss the following questions:
application/javascript
(default) MIME type to GraalJS and gets a special MIME type (comparable to what GraalJS currently has), e.g.application/javascript;version=ES5
Cc/ @rkoshak @digitaldan @J-N-K @cweitkamp @kaikreuzer @wborn (Sorry for pinging you all)
The text was updated successfully, but these errors were encountered: