Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] Improve German translation of channel types #13959

Closed
holgerfriedrich opened this issue Dec 15, 2022 · 10 comments · Fixed by #13962 or #13971
Closed

[knx] Improve German translation of channel types #13959

holgerfriedrich opened this issue Dec 15, 2022 · 10 comments · Fixed by #13962 or #13971
Labels
enhancement An enhancement or new feature for an existing add-on i18n

Comments

@holgerfriedrich
Copy link
Member

With regional setting of the browser configured to German, the "Add channel" dialog looks a bit strange. The translations seem to be done independently over time.

KNX distinguishes normal and "...-control" channels (see channel desc), and this is sometimes translated as "Kontrolle", sometimes as "Steuerung". Sometimes we use a hyphen, sometimes a space to separate the words. Just have a look here:
image

I know this is an issue for Crowdin, and I have already uploaded new suggestions. I think we need some coordination here and support from someone who can set/approve translations.

@holgerfriedrich holgerfriedrich added enhancement An enhancement or new feature for an existing add-on i18n labels Dec 15, 2022
@holgerfriedrich
Copy link
Member Author

ping @kaikreuzer

@florian-h05
Copy link
Contributor

@holgerfriedrich
As I‘ve contributed larger parts of the German translation, I think that I am able to influence it in some ways. I‘ve removed a few of my translations and upvoted yours to have „Steuerung“ instead of „Kontrolle“ and no hyphens for -control channels. Hopefully this makes Crowdin to use your translations instead.

@jlaur
Copy link
Contributor

jlaur commented Dec 15, 2022

@florian-h05 - can you also approve these four strings if they look correct to you?
image

To start the automatic workflow of creating a PR all strings must be translated and approved.

@florian-h05
Copy link
Contributor

florian-h05 commented Dec 15, 2022

Unfortunately no, I can't approve them. But they look good to me, so if you can approve @jlaur.
Looking at who approved the other strings, we can ping @cweitkamp to approve those strings.

@cweitkamp
Copy link
Contributor

@florian-h05 I granted you proofreading permission for German language on openhab-addons project in Crowdin. Have fun.

@florian-h05
Copy link
Contributor

Oh wow, thanks!

@jlaur I've approved the strings for KNX.

@holgerfriedrich holgerfriedrich linked a pull request Dec 15, 2022 that will close this issue
@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Dec 15, 2022

Thanks, everybody, it looks better now.

But still some inconsistencies (somehow the term "Kontakt-Kontrolle" is still there....,). @florian-h05 could you help to convince Crowdin to switch to the new translations? It seems we to approve the new translations again....
image

@florian-h05
Copy link
Contributor

Yes, I'll have a look at it this midday and convince Crowdin to to what we want.

@florian-h05
Copy link
Contributor

@holgerfriedrich I‘ve removed the incorrect translations and approved your translations, hopefully openhab-bot/Crowdin does open a PR now.

@holgerfriedrich holgerfriedrich linked a pull request Dec 16, 2022 that will close this issue
@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Dec 16, 2022

Thanks a lot, @florian-h05. PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on i18n
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants