Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdpowerview] Bridge handler dynamic channel refactoring #11852

Closed
jlaur opened this issue Dec 24, 2021 · 0 comments · Fixed by #11853
Closed

[hdpowerview] Bridge handler dynamic channel refactoring #11852

jlaur opened this issue Dec 24, 2021 · 0 comments · Fixed by #11853
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@jlaur
Copy link
Contributor

jlaur commented Dec 24, 2021

The bridge handler class HDPowerViewHubHandler has grown after:

Especially the logic for creating automation channels is quite large (> 100 lines) and should be extracted to a separate class. This will improve the readability of the class by removing some responsibilities also make it easier to cover by unit tests.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Dec 24, 2021
@jlaur jlaur changed the title [hdpowerview] HDPowerViewHubHandler refactoring [hdpowerview] Bridge handler dynamic channel refactoring Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant