Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[avmfritz] Handler tries to set brightness for blinds in version 3.2.0.M5 #11789

Closed
quidam opened this issue Dec 15, 2021 · 1 comment
Closed
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@quidam
Copy link
Contributor

quidam commented Dec 15, 2021

Expected Behavior

The binding does not attempt to set the brightness of blinds.

Current Behavior

As HAN-FUN blinds (bit mask 335888) identify themselves not only as blinds (bit 18 set), but also as dimmable lights (bit 16 set), the AVMFritzBaseThingHandler tries to update the channel "brightness", which doesn't exist. This leads to infinite messages like
Channel 'brightness' in thing 'avmfritz:HAN_FUN_BLINDS:192_168_nnn_n:nnnnnnnnn' does not exist, recreating thing.
This not only results in a multitude of log entries, but also prevents openHAB to correctly initialize the blinds resulting in an unknown state of the HAN-FUN things following the blinds.

Possible Solution

only set brightness when the thing is identified as a dimmable light and NOT as blinds. (I'm presently working on a PR)

Steps to Reproduce (for Bugs)

  1. Install avmfritz binding
  2. add a blinds thing and other HAN-FUN things
  3. set the log level to DEBUG for the binding
  4. analyze the openhab log

Your Environment

  • Version used: openHAB and add-on version 3.2.0.M5
  • Operating System and version: Raspbian Buster
@quidam quidam added the bug An unexpected problem or unintended behavior of an add-on label Dec 15, 2021
@lolodomo
Copy link
Contributor

Closed by #11790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

No branches or pull requests

2 participants