fix(deps): upgrade node, alpine and chromium #363
Merged
+38
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshuli
force-pushed
the
upgrade-docker-chromium
branch
2 times, most recently
from
a281c46 to
cc2a34e
Compare
tshuli
changed the title
This was referenced Sep 23, 2020
karrui
requested changes
Sep 24, 2020
Dockerfile.production
Outdated
| RUN apk update && apk upgrade && \ | ||
| apk --no-cache add --virtual native-deps \ | ||
| g++ gcc libgcc libstdc++ linux-headers autoconf automake make nasm python git curl && \ | ||
| g++ gcc libgcc libstdc++ linux-headers autoconf automake make nasm python2 git curl && \ |
There was a problem hiding this comment.
What is this python dependency used for anyways? I don't see any need for it in the prod dockerfile, since we don't use pip here
There was a problem hiding this comment.
node-gyp requires python dependency; there was a note in the troubleshooting guide that node-gyp only supports python 2 but that this is no longer the case; I've also updated the troubleshooting guide
Dockerfile.development
Outdated
| @@ -8,12 +8,15 @@ ENV NODE_ENV=development | |||
| RUN apk update && apk upgrade && \ | |||
| # Build dependencies for node_modules | |||
| apk add --virtual native-deps \ | |||
| g++ gcc libgcc libstdc++ linux-headers autoconf automake make nasm python git curl \ | |||
| # Python version must be specified starting in alpine3.12 | |||
| g++ gcc libgcc libstdc++ linux-headers autoconf automake make nasm python2 git curl \ | |||
There was a problem hiding this comment.
will python3 not work? python2 has reached end of life
There was a problem hiding this comment.
as above, changed to python3
Co-authored-by: Kar Rui Lau <[email protected]>
tshuli
force-pushed
the
upgrade-docker-chromium
branch
from
058ccbc to
12d16bd
Compare
This was referenced Sep 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #10
Solution