Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2?] Remove customMin and customMax virtuals from number and text field schemas #2039

Closed
tshuli opened this issue Jun 1, 2021 · 1 comment · Fixed by #6596
Closed

[2?] Remove customMin and customMax virtuals from number and text field schemas #2039

tshuli opened this issue Jun 1, 2021 · 1 comment · Fixed by #6596
Assignees
@r00dgirl
Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months

Comments

@tshuli
Copy link
Contributor

tshuli commented Jun 1, 2021

Remove customMin and customMax virtuals from number and text field schemas, which were put in to allow for backward compatibility after customMin and customMax were removed as part of #408
@mantariksh mantariksh mentioned this issue Jun 3, 2021
Merged
6 tasks
@r00dgirl r00dgirl added easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months labels Jun 3, 2021
@r00dgirl r00dgirl assigned r00dgirl and tshuli and unassigned r00dgirl Jun 3, 2021
@amitogp amitogp changed the title TODO: Remove customMin and customMax virtuals from number and text field schemas [2?] Remove customMin and customMax virtuals from number and text field schemas Oct 5, 2022
@justynoh
Copy link
Contributor

justynoh commented Aug 3, 2023

In particular, the following need to be removed:

  • Lines setting the virtuals (i.e. starting with ValidationOptionsSchema.virtual('customMin').get(function () in the files src/app/models/field/xxxField.ts (where xxx is the relevant field type - text/number etc)
  • The type generic in src/types/field/utils/virtuals.ts

@justynoh justynoh mentioned this issue Aug 3, 2023
Merged
22 tasks
@LeonardYam LeonardYam mentioned this issue Aug 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r00dgirl r00dgirl

Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove customMin and customMax virtuals LeonardYam/FormSG
3 participants
@justynoh @r00dgirl @tshuli