Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FormControl): update styling and fix focus on some inputs when clicked #260

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

karrui
Copy link
Collaborator

@karrui karrui commented Feb 23, 2023

This PR enhances the FormLabel and FormControl components.

Closes #258, closes #259

Theme

  • feat(FormLabel): add sizing, updated styling
  • feat: add Form Input stories for Single/MultiSelect and NumberInput

Fixes

  • fix: add displayName to FormLabel component
    • This fixes the bug where FormLabel with a FormControl parent will not focus on the input when label is clicked. Also fixes SSR bug with a hydration mismatch.

Deps

  • feat: update storybook to v7.0.0-beta.53

@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for objective-bell-0ffbfb canceled.

Name Link
🔨 Latest commit 5b2d102
🔍 Latest deploy log https://app.netlify.com/sites/objective-bell-0ffbfb/deploys/63fec191a3ae5e0007a71ce0

@karrui karrui force-pushed the feat/form-control-styling branch from 7884e82 to 3a4b04d Compare February 28, 2023 10:44
@karrui karrui merged commit b1206a5 into main Mar 6, 2023
@karrui karrui deleted the feat/form-control-styling branch March 6, 2023 07:32
@karrui karrui mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add size variants for FormLabel Clicking on FormLabel with SIngle/MultiSelect does not focus input
1 participant