From 0cb682e53fff5b0fed24ffc74ee9ee88ff026dd6 Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 18:26:50 +0800 Subject: [PATCH 1/6] Change to generic error msg --- src/loaders/express/error-handler.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/loaders/express/error-handler.ts b/src/loaders/express/error-handler.ts index 5f7630d524..e1b4e4950a 100644 --- a/src/loaders/express/error-handler.ts +++ b/src/loaders/express/error-handler.ts @@ -43,7 +43,9 @@ const errorHandlerMiddlewares = () => { }, error: err, }) - return res.status(StatusCodes.BAD_REQUEST).send(errorMessage) + return res + .status(StatusCodes.BAD_REQUEST) + .send('Some required parameters are missing') } logger.error({ From 588b24da28be5cb8a80847f6ee6c8f31cdc1c0b0 Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 18:33:03 +0800 Subject: [PATCH 2/6] Removed unused variable --- src/loaders/express/error-handler.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/loaders/express/error-handler.ts b/src/loaders/express/error-handler.ts index e1b4e4950a..ef3fd38a9f 100644 --- a/src/loaders/express/error-handler.ts +++ b/src/loaders/express/error-handler.ts @@ -28,11 +28,6 @@ const errorHandlerMiddlewares = () => { 'Apologies, something odd happened. Please try again later!' // Error page if (isCelebrate(err)) { - const errorMessage = get( - err, - 'joi.details[0].message', - genericErrorMessage, - ) // formId is only present for Joi validated routes that require it const formId = get(req, 'form._id', null) logger.error({ From 2ea5bae974a4dbfd9080408df3b177839d05b3c4 Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 18:48:22 +0800 Subject: [PATCH 3/6] chore: bump version to v4.35.1 --- CHANGELOG.md | 351 +++++++++++++++++++++++----------------------- package-lock.json | 2 +- package.json | 2 +- 3 files changed, 179 insertions(+), 176 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c594a4b4f..7af702c5b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,205 +4,208 @@ All notable changes to this project will be documented in this file. Dates are d Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). -#### [v4.35.0](https://github.com/opengovsg/FormSG/compare/v4.34.0...v4.35.0) - -> 15 September 2020 - -- refactor: turn on strict mode in Typescript configuration [`#262`](https://github.com/opengovsg/FormSG/pull/262) -- fix: allow inline styles from angular-sanitize [`#316`](https://github.com/opengovsg/FormSG/pull/316) -- feat(changelog): autogenerate CHANGELOG.md from conventional commits [`#306`](https://github.com/opengovsg/FormSG/pull/306) -- chore: reduce number of e2e tests and other fixes [`#305`](https://github.com/opengovsg/FormSG/pull/305) -- feat: merge release 4.34.1 into develop [`#312`](https://github.com/opengovsg/FormSG/pull/312) -- feat: log all critical bounces [`#288`](https://github.com/opengovsg/FormSG/pull/288) -- refactor(proxy): do not override X-Forwarded-Proto headers [`#304`](https://github.com/opengovsg/FormSG/pull/304) -- fix(deps): bump angular-translate-loader-partial from 2.18.2 to 2.18.3 [`#298`](https://github.com/opengovsg/FormSG/pull/298) -- chore(deps-dev): bump eslint-plugin-jest from 23.20.0 to 24.0.0 [`#299`](https://github.com/opengovsg/FormSG/pull/299) -- fix(deps): bump ejs from 2.7.4 to 3.1.5 [`#282`](https://github.com/opengovsg/FormSG/pull/282) -- chore: document env vars needed for EFS [`#303`](https://github.com/opengovsg/FormSG/pull/303) -- Greater clarity for available features, project roadmap and deployment instructions; disable E2E tests [`#301`](https://github.com/opengovsg/FormSG/pull/301) -- build: bump version to 4.34.1 [`d5bfd5a`](https://github.com/opengovsg/FormSG/commit/d5bfd5a60a9b006ad2329eb6ec95979b38522358) - -#### [v4.34.0](https://github.com/opengovsg/FormSG/compare/v4.33.0...v4.34.0) +#### [v4.35.1](https://github.com/opengovsg/formsg/compare/v4.34.0...v4.35.1) + +> 17 September 2020 + +- feat: update copy for email fields, intranet, privacy [`#321`](https://github.com/opengovsg/formsg/pull/321) +- refactor: turn on strict mode in Typescript configuration [`#262`](https://github.com/opengovsg/formsg/pull/262) +- fix: allow inline styles from angular-sanitize [`#316`](https://github.com/opengovsg/formsg/pull/316) +- feat(changelog): autogenerate CHANGELOG.md from conventional commits [`#306`](https://github.com/opengovsg/formsg/pull/306) +- chore: reduce number of e2e tests and other fixes [`#305`](https://github.com/opengovsg/formsg/pull/305) +- feat: merge release 4.34.1 into develop [`#312`](https://github.com/opengovsg/formsg/pull/312) +- feat: log all critical bounces [`#288`](https://github.com/opengovsg/formsg/pull/288) +- refactor(proxy): do not override X-Forwarded-Proto headers [`#304`](https://github.com/opengovsg/formsg/pull/304) +- fix(deps): bump angular-translate-loader-partial from 2.18.2 to 2.18.3 [`#298`](https://github.com/opengovsg/formsg/pull/298) +- chore(deps-dev): bump eslint-plugin-jest from 23.20.0 to 24.0.0 [`#299`](https://github.com/opengovsg/formsg/pull/299) +- fix(deps): bump ejs from 2.7.4 to 3.1.5 [`#282`](https://github.com/opengovsg/formsg/pull/282) +- chore: document env vars needed for EFS [`#303`](https://github.com/opengovsg/formsg/pull/303) +- Greater clarity for available features, project roadmap and deployment instructions; disable E2E tests [`#301`](https://github.com/opengovsg/formsg/pull/301) +- build: bump version to v4.35.0 [`fc7f9c9`](https://github.com/opengovsg/formsg/commit/fc7f9c92a5bcf65728bf0436e732f561b016be37) +- build: bump version to 4.34.1 [`d5bfd5a`](https://github.com/opengovsg/formsg/commit/d5bfd5a60a9b006ad2329eb6ec95979b38522358) +- Removed unused variable [`588b24d`](https://github.com/opengovsg/formsg/commit/588b24da28be5cb8a80847f6ee6c8f31cdc1c0b0) + +#### [v4.34.0](https://github.com/opengovsg/formsg/compare/v4.33.0...v4.34.0) > 8 September 2020 -- refactor: migrate /auth endpoint handling to Typescript, Domain Driven Design [`#215`](https://github.com/opengovsg/FormSG/pull/215) -- chore(deps-dev): bump stylelint-config-prettier from 8.0.1 to 8.0.2 [`#280`](https://github.com/opengovsg/FormSG/pull/280) -- fix: upgrade mongoose from 5.9.19 to 5.10.0 [`#289`](https://github.com/opengovsg/FormSG/pull/289) -- revert: reintroduce convict [`#287`](https://github.com/opengovsg/FormSG/pull/287) -- revert(convict): "refactor: use convict for configuration (#190)" [`#285`](https://github.com/opengovsg/FormSG/pull/285) -- chore(deps-dev): bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser [`#246`](https://github.com/opengovsg/FormSG/pull/246) -- feat: verified sms modal [`#274`](https://github.com/opengovsg/FormSG/pull/274) -- feat: add try-catch block to custom logger for js files [`#267`](https://github.com/opengovsg/FormSG/pull/267) -- fix: fix invocations of logger that does not adhere to expected shape [`#273`](https://github.com/opengovsg/FormSG/pull/273) -- chore(deps-dev): bump @babel/core from 7.10.2 to 7.11.5 [`#270`](https://github.com/opengovsg/FormSG/pull/270) -- feat: upgrade localstack version [`#275`](https://github.com/opengovsg/FormSG/pull/275) -- chore(deps-dev): bump testcafe from 1.8.6 to 1.9.1 [`#271`](https://github.com/opengovsg/FormSG/pull/271) -- chore(deps-dev): bump @babel/preset-env from 7.11.0 to 7.11.5 [`#268`](https://github.com/opengovsg/FormSG/pull/268) -- refactor: use convict for configuration [`#190`](https://github.com/opengovsg/FormSG/pull/190) -- fix: revert changes to configureAws [`#266`](https://github.com/opengovsg/FormSG/pull/266) -- refactor: remove redundant feature factory [`#261`](https://github.com/opengovsg/FormSG/pull/261) -- chore: remove form_field.isFutureOnly key [`#235`](https://github.com/opengovsg/FormSG/pull/235) -- refactor: remove unused Nodemailer env vars [`#253`](https://github.com/opengovsg/FormSG/pull/253) -- feat: upgrade Sentry SDK [`#254`](https://github.com/opengovsg/FormSG/pull/254) -- fix(deps): bump lodash from 4.17.19 to 4.17.20 [`#259`](https://github.com/opengovsg/FormSG/pull/259) -- chore(deps-dev): bump eslint from 7.7.0 to 7.8.1 [`#258`](https://github.com/opengovsg/FormSG/pull/258) -- chore(deps-dev): bump jest from 26.2.2 to 26.4.2 [`#257`](https://github.com/opengovsg/FormSG/pull/257) -- refactor: typify webhook and migrate from middleware pattern [`#251`](https://github.com/opengovsg/FormSG/pull/251) -- fix(dev): fix Localstack yet again [`#252`](https://github.com/opengovsg/FormSG/pull/252) -- chore(deps-dev): bump prettier from 2.0.5 to 2.1.1 [`#249`](https://github.com/opengovsg/FormSG/pull/249) -- fix: prevent discriminated models from being created before their base model [`#244`](https://github.com/opengovsg/FormSG/pull/244) -- fix(deps): remove ajv as dependency [`#248`](https://github.com/opengovsg/FormSG/pull/248) -- chore(deps-dev): bump @typescript-eslint/parser from 3.3.0 to 3.10.1 [`#247`](https://github.com/opengovsg/FormSG/pull/247) -- feat: merge Release 4.33.0 into develop [`#245`](https://github.com/opengovsg/FormSG/pull/245) -- Bump version [`830211a`](https://github.com/opengovsg/FormSG/commit/830211a541ff55ccd2fa1c74dc2ec4bfc29839ef) - -#### [v4.33.0](https://github.com/opengovsg/FormSG/compare/v4.32.1...v4.33.0) +- refactor: migrate /auth endpoint handling to Typescript, Domain Driven Design [`#215`](https://github.com/opengovsg/formsg/pull/215) +- chore(deps-dev): bump stylelint-config-prettier from 8.0.1 to 8.0.2 [`#280`](https://github.com/opengovsg/formsg/pull/280) +- fix: upgrade mongoose from 5.9.19 to 5.10.0 [`#289`](https://github.com/opengovsg/formsg/pull/289) +- revert: reintroduce convict [`#287`](https://github.com/opengovsg/formsg/pull/287) +- revert(convict): "refactor: use convict for configuration (#190)" [`#285`](https://github.com/opengovsg/formsg/pull/285) +- chore(deps-dev): bump @typescript-eslint/eslint-plugin and @typescript-eslint/parser [`#246`](https://github.com/opengovsg/formsg/pull/246) +- feat: verified sms modal [`#274`](https://github.com/opengovsg/formsg/pull/274) +- feat: add try-catch block to custom logger for js files [`#267`](https://github.com/opengovsg/formsg/pull/267) +- fix: fix invocations of logger that does not adhere to expected shape [`#273`](https://github.com/opengovsg/formsg/pull/273) +- chore(deps-dev): bump @babel/core from 7.10.2 to 7.11.5 [`#270`](https://github.com/opengovsg/formsg/pull/270) +- feat: upgrade localstack version [`#275`](https://github.com/opengovsg/formsg/pull/275) +- chore(deps-dev): bump testcafe from 1.8.6 to 1.9.1 [`#271`](https://github.com/opengovsg/formsg/pull/271) +- chore(deps-dev): bump @babel/preset-env from 7.11.0 to 7.11.5 [`#268`](https://github.com/opengovsg/formsg/pull/268) +- refactor: use convict for configuration [`#190`](https://github.com/opengovsg/formsg/pull/190) +- fix: revert changes to configureAws [`#266`](https://github.com/opengovsg/formsg/pull/266) +- refactor: remove redundant feature factory [`#261`](https://github.com/opengovsg/formsg/pull/261) +- chore: remove form_field.isFutureOnly key [`#235`](https://github.com/opengovsg/formsg/pull/235) +- refactor: remove unused Nodemailer env vars [`#253`](https://github.com/opengovsg/formsg/pull/253) +- feat: upgrade Sentry SDK [`#254`](https://github.com/opengovsg/formsg/pull/254) +- fix(deps): bump lodash from 4.17.19 to 4.17.20 [`#259`](https://github.com/opengovsg/formsg/pull/259) +- chore(deps-dev): bump eslint from 7.7.0 to 7.8.1 [`#258`](https://github.com/opengovsg/formsg/pull/258) +- chore(deps-dev): bump jest from 26.2.2 to 26.4.2 [`#257`](https://github.com/opengovsg/formsg/pull/257) +- refactor: typify webhook and migrate from middleware pattern [`#251`](https://github.com/opengovsg/formsg/pull/251) +- fix(dev): fix Localstack yet again [`#252`](https://github.com/opengovsg/formsg/pull/252) +- chore(deps-dev): bump prettier from 2.0.5 to 2.1.1 [`#249`](https://github.com/opengovsg/formsg/pull/249) +- fix: prevent discriminated models from being created before their base model [`#244`](https://github.com/opengovsg/formsg/pull/244) +- fix(deps): remove ajv as dependency [`#248`](https://github.com/opengovsg/formsg/pull/248) +- chore(deps-dev): bump @typescript-eslint/parser from 3.3.0 to 3.10.1 [`#247`](https://github.com/opengovsg/formsg/pull/247) +- feat: merge Release 4.33.0 into develop [`#245`](https://github.com/opengovsg/formsg/pull/245) +- Bump version [`830211a`](https://github.com/opengovsg/formsg/commit/830211a541ff55ccd2fa1c74dc2ec4bfc29839ef) + +#### [v4.33.0](https://github.com/opengovsg/formsg/compare/v4.32.1...v4.33.0) > 1 September 2020 -- fix: use original questionCount [`#242`](https://github.com/opengovsg/FormSG/pull/242) -- fix: correct left margin in acknowledgment error when activating storage mode form [`#240`](https://github.com/opengovsg/FormSG/pull/240) -- feat: log more info about critical bounces [`#237`](https://github.com/opengovsg/FormSG/pull/237) -- fix: remove filetype from permission levels imports [`#236`](https://github.com/opengovsg/FormSG/pull/236) -- fix(deps): bump http-status-codes from 1.4.0 to 2.1.2 [`#229`](https://github.com/opengovsg/FormSG/pull/229) -- refactor: use express router for modules [`#204`](https://github.com/opengovsg/FormSG/pull/204) -- chore(deps-dev): bump @types/helmet from 0.0.47 to 0.0.48 [`#232`](https://github.com/opengovsg/FormSG/pull/232) -- refactor(utils/attachment): typescriptify [`#166`](https://github.com/opengovsg/FormSG/pull/166) -- fix(deps): bump validator from 11.1.0 to 13.1.1 [`#209`](https://github.com/opengovsg/FormSG/pull/209) -- refactor: typify utils [`#171`](https://github.com/opengovsg/FormSG/pull/171) -- feat: mailto option after form activation [`#213`](https://github.com/opengovsg/FormSG/pull/213) -- fix(deps): bump axios from 0.19.2 to 0.20.0 [`#218`](https://github.com/opengovsg/FormSG/pull/218) -- chore(deps-dev): bump @types/mongoose from 5.7.25 to 5.7.36 [`#230`](https://github.com/opengovsg/FormSG/pull/230) -- feat: Bulk download of storage mode attachments in a zip file [`#141`](https://github.com/opengovsg/FormSG/pull/141) -- feat: merge release v4.32.1 back into develop branch [`#226`](https://github.com/opengovsg/FormSG/pull/226) -- fix(deps): bump opossum from 5.0.0 to 5.0.1 [`#221`](https://github.com/opengovsg/FormSG/pull/221) -- chore(deps-dev): bump eslint from 6.8.0 to 7.7.0 [`#220`](https://github.com/opengovsg/FormSG/pull/220) -- feat: standardize logger format and output [`#211`](https://github.com/opengovsg/FormSG/pull/211) -- fix: fix linting not working on frontend code [`#217`](https://github.com/opengovsg/FormSG/pull/217) -- fix: pass missing $state param into EditContactNumberModalController [`#216`](https://github.com/opengovsg/FormSG/pull/216) -- feat: add Emergency Contact feature frontend [`#142`](https://github.com/opengovsg/FormSG/pull/142) -- refactor: convert webhook service to Typescript [`#83`](https://github.com/opengovsg/FormSG/pull/83) -- chore(deps-dev): bump sinon from 6.3.5 to 9.0.3 [`#207`](https://github.com/opengovsg/FormSG/pull/207) -- feat: Share form secret keys across browser tabs using BroadcastChannel [`#203`](https://github.com/opengovsg/FormSG/pull/203) -- chore: merge Release v4.32.0 into develop branch [`#205`](https://github.com/opengovsg/FormSG/pull/205) -- Introduce minimum test coverage thresholds, coveralls.io for threshold reporting and repo badge [`#185`](https://github.com/opengovsg/FormSG/pull/185) -- feat: MailService#sendNodeMail invocations to retry on 4xx errors(#227) [`61d5103`](https://github.com/opengovsg/FormSG/commit/61d510312affdea6e971147dd547a6f5449b270b) -- build: bump version to 4.33.0 [`6c0951e`](https://github.com/opengovsg/FormSG/commit/6c0951e877e498751c94a539ce93b03eb0ff9d53) - -#### [v4.32.1](https://github.com/opengovsg/FormSG/compare/v4.32.0...v4.32.1) +- fix: use original questionCount [`#242`](https://github.com/opengovsg/formsg/pull/242) +- fix: correct left margin in acknowledgment error when activating storage mode form [`#240`](https://github.com/opengovsg/formsg/pull/240) +- feat: log more info about critical bounces [`#237`](https://github.com/opengovsg/formsg/pull/237) +- fix: remove filetype from permission levels imports [`#236`](https://github.com/opengovsg/formsg/pull/236) +- fix(deps): bump http-status-codes from 1.4.0 to 2.1.2 [`#229`](https://github.com/opengovsg/formsg/pull/229) +- refactor: use express router for modules [`#204`](https://github.com/opengovsg/formsg/pull/204) +- chore(deps-dev): bump @types/helmet from 0.0.47 to 0.0.48 [`#232`](https://github.com/opengovsg/formsg/pull/232) +- refactor(utils/attachment): typescriptify [`#166`](https://github.com/opengovsg/formsg/pull/166) +- fix(deps): bump validator from 11.1.0 to 13.1.1 [`#209`](https://github.com/opengovsg/formsg/pull/209) +- refactor: typify utils [`#171`](https://github.com/opengovsg/formsg/pull/171) +- feat: mailto option after form activation [`#213`](https://github.com/opengovsg/formsg/pull/213) +- fix(deps): bump axios from 0.19.2 to 0.20.0 [`#218`](https://github.com/opengovsg/formsg/pull/218) +- chore(deps-dev): bump @types/mongoose from 5.7.25 to 5.7.36 [`#230`](https://github.com/opengovsg/formsg/pull/230) +- feat: Bulk download of storage mode attachments in a zip file [`#141`](https://github.com/opengovsg/formsg/pull/141) +- feat: merge release v4.32.1 back into develop branch [`#226`](https://github.com/opengovsg/formsg/pull/226) +- fix(deps): bump opossum from 5.0.0 to 5.0.1 [`#221`](https://github.com/opengovsg/formsg/pull/221) +- chore(deps-dev): bump eslint from 6.8.0 to 7.7.0 [`#220`](https://github.com/opengovsg/formsg/pull/220) +- feat: standardize logger format and output [`#211`](https://github.com/opengovsg/formsg/pull/211) +- fix: fix linting not working on frontend code [`#217`](https://github.com/opengovsg/formsg/pull/217) +- fix: pass missing $state param into EditContactNumberModalController [`#216`](https://github.com/opengovsg/formsg/pull/216) +- feat: add Emergency Contact feature frontend [`#142`](https://github.com/opengovsg/formsg/pull/142) +- refactor: convert webhook service to Typescript [`#83`](https://github.com/opengovsg/formsg/pull/83) +- chore(deps-dev): bump sinon from 6.3.5 to 9.0.3 [`#207`](https://github.com/opengovsg/formsg/pull/207) +- feat: Share form secret keys across browser tabs using BroadcastChannel [`#203`](https://github.com/opengovsg/formsg/pull/203) +- chore: merge Release v4.32.0 into develop branch [`#205`](https://github.com/opengovsg/formsg/pull/205) +- Introduce minimum test coverage thresholds, coveralls.io for threshold reporting and repo badge [`#185`](https://github.com/opengovsg/formsg/pull/185) +- feat: MailService#sendNodeMail invocations to retry on 4xx errors(#227) [`61d5103`](https://github.com/opengovsg/formsg/commit/61d510312affdea6e971147dd547a6f5449b270b) +- build: bump version to 4.33.0 [`6c0951e`](https://github.com/opengovsg/formsg/commit/6c0951e877e498751c94a539ce93b03eb0ff9d53) + +#### [v4.32.1](https://github.com/opengovsg/formsg/compare/v4.32.0...v4.32.1) > 27 August 2020 -- chore: bump version to v4.32.1 [`0bf07cf`](https://github.com/opengovsg/FormSG/commit/0bf07cfc9b804a2e602a096032065d73805acfea) -- fix: split mail by semicolon in addition to comma when validating [`824380e`](https://github.com/opengovsg/FormSG/commit/824380ef2a015674b5931cc3f9516036eb80a917) +- chore: bump version to v4.32.1 [`0bf07cf`](https://github.com/opengovsg/formsg/commit/0bf07cfc9b804a2e602a096032065d73805acfea) +- fix: split mail by semicolon in addition to comma when validating [`824380e`](https://github.com/opengovsg/formsg/commit/824380ef2a015674b5931cc3f9516036eb80a917) -#### [v4.32.0](https://github.com/opengovsg/FormSG/compare/v4.30.4...v4.32.0) +#### [v4.32.0](https://github.com/opengovsg/formsg/compare/v4.30.4...v4.32.0) > 25 August 2020 -- fix: shift userEmail retrieval to GA service [`#192`](https://github.com/opengovsg/FormSG/pull/192) -- chore(deps-dev): bump @opengovsg/mockpass from 2.2.0 to 2.4.6 [`#198`](https://github.com/opengovsg/FormSG/pull/198) -- feat: remove beta field validations [`#194`](https://github.com/opengovsg/FormSG/pull/194) -- fix(deps): bump uid-generator from 1.0.0 to 2.0.0 [`#187`](https://github.com/opengovsg/FormSG/pull/187) -- fix(deps): bump puppeteer-core from 4.0.0 to 5.2.1 [`#188`](https://github.com/opengovsg/FormSG/pull/188) -- chore(deps-dev): bump @typescript-eslint/eslint-plugin [`#197`](https://github.com/opengovsg/FormSG/pull/197) -- feat: add core ApplicationError for express app [`#195`](https://github.com/opengovsg/FormSG/pull/195) -- chore(deps-dev): bump typescript to 4.0.2 [`#196`](https://github.com/opengovsg/FormSG/pull/196) -- fix(deps): bump font-awesome from 4.6.1 to 4.7.0 [`#186`](https://github.com/opengovsg/FormSG/pull/186) -- feat: migrate `util/response` to new Submission module (service, utils, etc) [`#176`](https://github.com/opengovsg/FormSG/pull/176) -- feat: log form ID in GA event labels [`#154`](https://github.com/opengovsg/FormSG/pull/154) -- refactor(verification): convert to module and typescriptify [`#172`](https://github.com/opengovsg/FormSG/pull/172) -- feat: support &`;'" in form title [`#156`](https://github.com/opengovsg/FormSG/pull/156) -- fix: run npm audit fix to resolve security issues with minimist dependency in the selectize package [`#181`](https://github.com/opengovsg/FormSG/pull/181) -- chore(deps-dev): bump jasmine from 3.5.0 to 3.6.1 [`#158`](https://github.com/opengovsg/FormSG/pull/158) -- chore(deps-dev): bump env-cmd from 9.0.3 to 10.1.0 [`#133`](https://github.com/opengovsg/FormSG/pull/133) -- feat: mailto link for secret key [`#150`](https://github.com/opengovsg/FormSG/pull/150) -- fix: enable forceDelivery on twilio message sending [`#178`](https://github.com/opengovsg/FormSG/pull/178) -- feat: increase breaker window time and add minimum volume threshold [`#165`](https://github.com/opengovsg/FormSG/pull/165) -- refactor: migrate encryption util to typescript [`#167`](https://github.com/opengovsg/FormSG/pull/167) -- refactor: delete render promise util [`#168`](https://github.com/opengovsg/FormSG/pull/168) -- refactor: convert date util to typescript [`#161`](https://github.com/opengovsg/FormSG/pull/161) -- feat: create bounce collection and alarms [`#131`](https://github.com/opengovsg/FormSG/pull/131) -- [develop] Release v4.31.0 [`#155`](https://github.com/opengovsg/FormSG/pull/155) -- refactor: convert MailService to a class based Typescript implementation [`#76`](https://github.com/opengovsg/FormSG/pull/76) -- fix(deps): bump aws-sdk from 2.699.0 to 2.734.0 [`#146`](https://github.com/opengovsg/FormSG/pull/146) -- fix(deps): bump node-cache from 5.1.1 to 5.1.2 [`#145`](https://github.com/opengovsg/FormSG/pull/145) -- feat: include user ip address when sending otp [`#147`](https://github.com/opengovsg/FormSG/pull/147) -- chore(deps-dev): bump htmlhint from 0.11.0 to 0.14.1 [`#116`](https://github.com/opengovsg/FormSG/pull/116) -- fix(deps): bump angular-* dependency packages from 1.7.9 to 1.8.0 [`#108`](https://github.com/opengovsg/FormSG/pull/108) -- feat: log IP, submissionId and formId together [`#130`](https://github.com/opengovsg/FormSG/pull/130) -- fix(deps): bump crypto-js from 3.3.0 to 4.0.0 [`#110`](https://github.com/opengovsg/FormSG/pull/110) -- [develop] Release 4.30.4 [`#138`](https://github.com/opengovsg/FormSG/pull/138) -- fix(deps): bump express-winston from 4.0.3 to 4.0.5 [`#109`](https://github.com/opengovsg/FormSG/pull/109) -- chore: add --watch flag back to build-frontend-dev script [`#128`](https://github.com/opengovsg/FormSG/pull/128) -- docs: create trouble shooting guide [`#119`](https://github.com/opengovsg/FormSG/pull/119) -- chore: Merge release 4.30.3 into develop [`#127`](https://github.com/opengovsg/FormSG/pull/127) -- fix(deps): bump bcrypt from 3.0.8 to 5.0.0 [`#88`](https://github.com/opengovsg/FormSG/pull/88) -- fix(deps): bump nodemailer from 6.4.10 to 6.4.11 [`#117`](https://github.com/opengovsg/FormSG/pull/117) -- tests: fix flakiness and migrate remaining mongoose model tests to Typescript [`#122`](https://github.com/opengovsg/FormSG/pull/122) -- chore: bump version to v4.32.0 [`aa34114`](https://github.com/opengovsg/FormSG/commit/aa341141d47a806ece786fcccbe0faef0945ccfc) - -#### [v4.30.4](https://github.com/opengovsg/FormSG/compare/v4.30.3...v4.30.4) +- fix: shift userEmail retrieval to GA service [`#192`](https://github.com/opengovsg/formsg/pull/192) +- chore(deps-dev): bump @opengovsg/mockpass from 2.2.0 to 2.4.6 [`#198`](https://github.com/opengovsg/formsg/pull/198) +- feat: remove beta field validations [`#194`](https://github.com/opengovsg/formsg/pull/194) +- fix(deps): bump uid-generator from 1.0.0 to 2.0.0 [`#187`](https://github.com/opengovsg/formsg/pull/187) +- fix(deps): bump puppeteer-core from 4.0.0 to 5.2.1 [`#188`](https://github.com/opengovsg/formsg/pull/188) +- chore(deps-dev): bump @typescript-eslint/eslint-plugin [`#197`](https://github.com/opengovsg/formsg/pull/197) +- feat: add core ApplicationError for express app [`#195`](https://github.com/opengovsg/formsg/pull/195) +- chore(deps-dev): bump typescript to 4.0.2 [`#196`](https://github.com/opengovsg/formsg/pull/196) +- fix(deps): bump font-awesome from 4.6.1 to 4.7.0 [`#186`](https://github.com/opengovsg/formsg/pull/186) +- feat: migrate `util/response` to new Submission module (service, utils, etc) [`#176`](https://github.com/opengovsg/formsg/pull/176) +- feat: log form ID in GA event labels [`#154`](https://github.com/opengovsg/formsg/pull/154) +- refactor(verification): convert to module and typescriptify [`#172`](https://github.com/opengovsg/formsg/pull/172) +- feat: support &`;'" in form title [`#156`](https://github.com/opengovsg/formsg/pull/156) +- fix: run npm audit fix to resolve security issues with minimist dependency in the selectize package [`#181`](https://github.com/opengovsg/formsg/pull/181) +- chore(deps-dev): bump jasmine from 3.5.0 to 3.6.1 [`#158`](https://github.com/opengovsg/formsg/pull/158) +- chore(deps-dev): bump env-cmd from 9.0.3 to 10.1.0 [`#133`](https://github.com/opengovsg/formsg/pull/133) +- feat: mailto link for secret key [`#150`](https://github.com/opengovsg/formsg/pull/150) +- fix: enable forceDelivery on twilio message sending [`#178`](https://github.com/opengovsg/formsg/pull/178) +- feat: increase breaker window time and add minimum volume threshold [`#165`](https://github.com/opengovsg/formsg/pull/165) +- refactor: migrate encryption util to typescript [`#167`](https://github.com/opengovsg/formsg/pull/167) +- refactor: delete render promise util [`#168`](https://github.com/opengovsg/formsg/pull/168) +- refactor: convert date util to typescript [`#161`](https://github.com/opengovsg/formsg/pull/161) +- feat: create bounce collection and alarms [`#131`](https://github.com/opengovsg/formsg/pull/131) +- [develop] Release v4.31.0 [`#155`](https://github.com/opengovsg/formsg/pull/155) +- refactor: convert MailService to a class based Typescript implementation [`#76`](https://github.com/opengovsg/formsg/pull/76) +- fix(deps): bump aws-sdk from 2.699.0 to 2.734.0 [`#146`](https://github.com/opengovsg/formsg/pull/146) +- fix(deps): bump node-cache from 5.1.1 to 5.1.2 [`#145`](https://github.com/opengovsg/formsg/pull/145) +- feat: include user ip address when sending otp [`#147`](https://github.com/opengovsg/formsg/pull/147) +- chore(deps-dev): bump htmlhint from 0.11.0 to 0.14.1 [`#116`](https://github.com/opengovsg/formsg/pull/116) +- fix(deps): bump angular-* dependency packages from 1.7.9 to 1.8.0 [`#108`](https://github.com/opengovsg/formsg/pull/108) +- feat: log IP, submissionId and formId together [`#130`](https://github.com/opengovsg/formsg/pull/130) +- fix(deps): bump crypto-js from 3.3.0 to 4.0.0 [`#110`](https://github.com/opengovsg/formsg/pull/110) +- [develop] Release 4.30.4 [`#138`](https://github.com/opengovsg/formsg/pull/138) +- fix(deps): bump express-winston from 4.0.3 to 4.0.5 [`#109`](https://github.com/opengovsg/formsg/pull/109) +- chore: add --watch flag back to build-frontend-dev script [`#128`](https://github.com/opengovsg/formsg/pull/128) +- docs: create trouble shooting guide [`#119`](https://github.com/opengovsg/formsg/pull/119) +- chore: Merge release 4.30.3 into develop [`#127`](https://github.com/opengovsg/formsg/pull/127) +- fix(deps): bump bcrypt from 3.0.8 to 5.0.0 [`#88`](https://github.com/opengovsg/formsg/pull/88) +- fix(deps): bump nodemailer from 6.4.10 to 6.4.11 [`#117`](https://github.com/opengovsg/formsg/pull/117) +- tests: fix flakiness and migrate remaining mongoose model tests to Typescript [`#122`](https://github.com/opengovsg/formsg/pull/122) +- chore: bump version to v4.32.0 [`aa34114`](https://github.com/opengovsg/formsg/commit/aa341141d47a806ece786fcccbe0faef0945ccfc) + +#### [v4.30.4](https://github.com/opengovsg/formsg/compare/v4.30.3...v4.30.4) > 14 August 2020 -- Revert "feat: Filter Storage Mode Responses by Submission Id (#71)" [`ffe4218`](https://github.com/opengovsg/FormSG/commit/ffe42187130d1d4147f22b37687992062af7d7c6) -- chore: bump version to 4.30.4 [`35d68de`](https://github.com/opengovsg/FormSG/commit/35d68debce62bd86f001724608bbc59bce483aa3) +- Revert "feat: Filter Storage Mode Responses by Submission Id (#71)" [`ffe4218`](https://github.com/opengovsg/formsg/commit/ffe42187130d1d4147f22b37687992062af7d7c6) +- chore: bump version to 4.30.4 [`35d68de`](https://github.com/opengovsg/formsg/commit/35d68debce62bd86f001724608bbc59bce483aa3) -#### [v4.30.3](https://github.com/opengovsg/FormSG/compare/v4.30.2...v4.30.3) +#### [v4.30.3](https://github.com/opengovsg/formsg/compare/v4.30.2...v4.30.3) > 12 August 2020 -- fix: Revert url loader [`#125`](https://github.com/opengovsg/FormSG/pull/125) -- feat: show error upon FileReader failure [`#121`](https://github.com/opengovsg/FormSG/pull/121) -- [develop] Release 4.30.2 [`#114`](https://github.com/opengovsg/FormSG/pull/114) -- refactor: remove unused mongoTimestamp plugin [`#120`](https://github.com/opengovsg/FormSG/pull/120) -- docs: updating contributing, readme, license for open source [`#86`](https://github.com/opengovsg/FormSG/pull/86) -- chore: setup jest for use with Typescript tests [`#106`](https://github.com/opengovsg/FormSG/pull/106) -- fix: fix myInfoError typo [`#115`](https://github.com/opengovsg/FormSG/pull/115) -- docs(readme): point build status image to new repo [`#112`](https://github.com/opengovsg/FormSG/pull/112) -- feat: add getQuestion instance method to form field schema [`#103`](https://github.com/opengovsg/FormSG/pull/103) -- chore(deps-dev): bump webpack-cli from 3.3.11 to 3.3.12 [`#105`](https://github.com/opengovsg/FormSG/pull/105) -- feat: Filter Storage Mode Responses by Submission Id [`#71`](https://github.com/opengovsg/FormSG/pull/71) -- fix(deps): bump angular-cookies from 1.7.9 to 1.8.0 [`#104`](https://github.com/opengovsg/FormSG/pull/104) -- chore(deps-dev): bump angular from 1.7.9 to 1.8.0 [`#10`](https://github.com/opengovsg/FormSG/pull/10) -- docs: updated docs for open source [`#95`](https://github.com/opengovsg/FormSG/pull/95) -- test: add tests for verification model [`#99`](https://github.com/opengovsg/FormSG/pull/99) -- chore(deps-dev): bump url-loader from 1.1.2 to 4.1.0 [`#90`](https://github.com/opengovsg/FormSG/pull/90) -- refactor: migrate `utils/request` to Typescript [`#98`](https://github.com/opengovsg/FormSG/pull/98) -- fix: phone validation now only accepts 8 digit #s starting with 8 or 9 [`#101`](https://github.com/opengovsg/FormSG/pull/101) -- [develop] Release 4.30.1 [`#80`](https://github.com/opengovsg/FormSG/pull/80) -- [develop] Release 4.30.0 [`#79`](https://github.com/opengovsg/FormSG/pull/79) -- fix(deps): bump uuid from 8.2.0 to 8.3.0 [`#96`](https://github.com/opengovsg/FormSG/pull/96) -- chore(deps-dev): bump jasmine-spec-reporter from 4.2.1 to 5.0.2 [`#89`](https://github.com/opengovsg/FormSG/pull/89) -- chore(deps-dev): bump @babel/preset-env from 7.10.2 to 7.11.0 [`#87`](https://github.com/opengovsg/FormSG/pull/87) -- fix(deps): bump lodash from 4.17.15 to 4.17.19 [`#91`](https://github.com/opengovsg/FormSG/pull/91) -- refactor(logic): typescriptify [`#81`](https://github.com/opengovsg/FormSG/pull/81) -- fix: update dependabot config to use v2 syntax [`#85`](https://github.com/opengovsg/FormSG/pull/85) -- chore: add dependabot.yml [`#82`](https://github.com/opengovsg/FormSG/pull/82) -- feat: remove allowSms beta flag [`#73`](https://github.com/opengovsg/FormSG/pull/73) -- feat(FormSchema): Document new indexes for form dashboard [`#77`](https://github.com/opengovsg/FormSG/pull/77) -- refactor: add _id to all model interfaces [`#75`](https://github.com/opengovsg/FormSG/pull/75) -- Bump version to 4.30.3 [`4e97a48`](https://github.com/opengovsg/FormSG/commit/4e97a48e52eefa621b1ef84f1d991d90e96a57b4) - -#### [v4.30.2](https://github.com/opengovsg/FormSG/compare/v4.30.1...v4.30.2) +- fix: Revert url loader [`#125`](https://github.com/opengovsg/formsg/pull/125) +- feat: show error upon FileReader failure [`#121`](https://github.com/opengovsg/formsg/pull/121) +- [develop] Release 4.30.2 [`#114`](https://github.com/opengovsg/formsg/pull/114) +- refactor: remove unused mongoTimestamp plugin [`#120`](https://github.com/opengovsg/formsg/pull/120) +- docs: updating contributing, readme, license for open source [`#86`](https://github.com/opengovsg/formsg/pull/86) +- chore: setup jest for use with Typescript tests [`#106`](https://github.com/opengovsg/formsg/pull/106) +- fix: fix myInfoError typo [`#115`](https://github.com/opengovsg/formsg/pull/115) +- docs(readme): point build status image to new repo [`#112`](https://github.com/opengovsg/formsg/pull/112) +- feat: add getQuestion instance method to form field schema [`#103`](https://github.com/opengovsg/formsg/pull/103) +- chore(deps-dev): bump webpack-cli from 3.3.11 to 3.3.12 [`#105`](https://github.com/opengovsg/formsg/pull/105) +- feat: Filter Storage Mode Responses by Submission Id [`#71`](https://github.com/opengovsg/formsg/pull/71) +- fix(deps): bump angular-cookies from 1.7.9 to 1.8.0 [`#104`](https://github.com/opengovsg/formsg/pull/104) +- chore(deps-dev): bump angular from 1.7.9 to 1.8.0 [`#10`](https://github.com/opengovsg/formsg/pull/10) +- docs: updated docs for open source [`#95`](https://github.com/opengovsg/formsg/pull/95) +- test: add tests for verification model [`#99`](https://github.com/opengovsg/formsg/pull/99) +- chore(deps-dev): bump url-loader from 1.1.2 to 4.1.0 [`#90`](https://github.com/opengovsg/formsg/pull/90) +- refactor: migrate `utils/request` to Typescript [`#98`](https://github.com/opengovsg/formsg/pull/98) +- fix: phone validation now only accepts 8 digit #s starting with 8 or 9 [`#101`](https://github.com/opengovsg/formsg/pull/101) +- [develop] Release 4.30.1 [`#80`](https://github.com/opengovsg/formsg/pull/80) +- [develop] Release 4.30.0 [`#79`](https://github.com/opengovsg/formsg/pull/79) +- fix(deps): bump uuid from 8.2.0 to 8.3.0 [`#96`](https://github.com/opengovsg/formsg/pull/96) +- chore(deps-dev): bump jasmine-spec-reporter from 4.2.1 to 5.0.2 [`#89`](https://github.com/opengovsg/formsg/pull/89) +- chore(deps-dev): bump @babel/preset-env from 7.10.2 to 7.11.0 [`#87`](https://github.com/opengovsg/formsg/pull/87) +- fix(deps): bump lodash from 4.17.15 to 4.17.19 [`#91`](https://github.com/opengovsg/formsg/pull/91) +- refactor(logic): typescriptify [`#81`](https://github.com/opengovsg/formsg/pull/81) +- fix: update dependabot config to use v2 syntax [`#85`](https://github.com/opengovsg/formsg/pull/85) +- chore: add dependabot.yml [`#82`](https://github.com/opengovsg/formsg/pull/82) +- feat: remove allowSms beta flag [`#73`](https://github.com/opengovsg/formsg/pull/73) +- feat(FormSchema): Document new indexes for form dashboard [`#77`](https://github.com/opengovsg/formsg/pull/77) +- refactor: add _id to all model interfaces [`#75`](https://github.com/opengovsg/formsg/pull/75) +- Bump version to 4.30.3 [`4e97a48`](https://github.com/opengovsg/formsg/commit/4e97a48e52eefa621b1ef84f1d991d90e96a57b4) + +#### [v4.30.2](https://github.com/opengovsg/formsg/compare/v4.30.1...v4.30.2) > 5 August 2020 -- fix: get env vars directly, not from config [`5397c06`](https://github.com/opengovsg/FormSG/commit/5397c06107f52d7d3d5032ce6507daeb9d0604cf) -- fix: add trailing / only for attachments [`1b9d1c0`](https://github.com/opengovsg/FormSG/commit/1b9d1c045c4f250533452f8a0448b37ebd6346f7) -- chore: bump version to 4.30.2 [`f623c1a`](https://github.com/opengovsg/FormSG/commit/f623c1abb8bd85dd06d36994c783ed0409cd8a5d) +- fix: get env vars directly, not from config [`5397c06`](https://github.com/opengovsg/formsg/commit/5397c06107f52d7d3d5032ce6507daeb9d0604cf) +- fix: add trailing / only for attachments [`1b9d1c0`](https://github.com/opengovsg/formsg/commit/1b9d1c045c4f250533452f8a0448b37ebd6346f7) +- chore: bump version to 4.30.2 [`f623c1a`](https://github.com/opengovsg/formsg/commit/f623c1abb8bd85dd06d36994c783ed0409cd8a5d) #### v4.30.1 > 4 August 2020 -- fix: change enum to uppercase [`#72`](https://github.com/opengovsg/FormSG/pull/72) -- fix: activation modal width change when activation succeeds [`#69`](https://github.com/opengovsg/FormSG/pull/69) -- Extend e2e [`#65`](https://github.com/opengovsg/FormSG/pull/65) -- chore: update documentation for banner environment variables [`#3`](https://github.com/opengovsg/FormSG/pull/3) -- fix: add fake aws credentials [`#64`](https://github.com/opengovsg/FormSG/pull/64) -- Initial commit [`203e62d`](https://github.com/opengovsg/FormSG/commit/203e62dfc346cef9fb893c7b84c481b762216dea) -- chore: bump version to 4.30.1 [`9ea64ac`](https://github.com/opengovsg/FormSG/commit/9ea64ac0c19df843839357223abda0d449603704) -- chore: bump version to 4.30.0 [`bf0cca8`](https://github.com/opengovsg/FormSG/commit/bf0cca862f9c25b0984986aae295b42938c81884) +- fix: change enum to uppercase [`#72`](https://github.com/opengovsg/formsg/pull/72) +- fix: activation modal width change when activation succeeds [`#69`](https://github.com/opengovsg/formsg/pull/69) +- Extend e2e [`#65`](https://github.com/opengovsg/formsg/pull/65) +- chore: update documentation for banner environment variables [`#3`](https://github.com/opengovsg/formsg/pull/3) +- fix: add fake aws credentials [`#64`](https://github.com/opengovsg/formsg/pull/64) +- Initial commit [`203e62d`](https://github.com/opengovsg/formsg/commit/203e62dfc346cef9fb893c7b84c481b762216dea) +- chore: bump version to 4.30.1 [`9ea64ac`](https://github.com/opengovsg/formsg/commit/9ea64ac0c19df843839357223abda0d449603704) +- chore: bump version to 4.30.0 [`bf0cca8`](https://github.com/opengovsg/formsg/commit/bf0cca862f9c25b0984986aae295b42938c81884) diff --git a/package-lock.json b/package-lock.json index d218b2405a..889ce93bc5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "FormSG", - "version": "4.35.0", + "version": "4.35.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index d6c4289a65..fc71dcde4c 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "FormSG", "description": "Form Manager for Government", - "version": "4.35.0", + "version": "4.35.1", "homepage": "https://form.gov.sg", "authors": [ "FormSG " From 6d0ffde17207589d34c760f1b0aa9825d0323d0b Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 19:15:52 +0800 Subject: [PATCH 4/6] Fix tests --- src/app/modules/auth/__tests__/auth.routes.spec.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/modules/auth/__tests__/auth.routes.spec.ts b/src/app/modules/auth/__tests__/auth.routes.spec.ts index b6606de02e..91994359d1 100644 --- a/src/app/modules/auth/__tests__/auth.routes.spec.ts +++ b/src/app/modules/auth/__tests__/auth.routes.spec.ts @@ -32,7 +32,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('"email" is required') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.email is invalid', async () => { @@ -122,7 +122,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('"email" is required') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.email is invalid', async () => { @@ -254,7 +254,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('"email" is required') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.otp is not provided as a param', async () => { @@ -265,7 +265,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('"otp" is required') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.email is invalid', async () => { From 0c6c8acfa95a591449e90dea229b50bc5b73a7c4 Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 19:33:16 +0800 Subject: [PATCH 5/6] Fix more tests --- src/app/modules/auth/__tests__/auth.routes.spec.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/modules/auth/__tests__/auth.routes.spec.ts b/src/app/modules/auth/__tests__/auth.routes.spec.ts index 91994359d1..fa3e69b9f6 100644 --- a/src/app/modules/auth/__tests__/auth.routes.spec.ts +++ b/src/app/modules/auth/__tests__/auth.routes.spec.ts @@ -46,7 +46,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('Please enter a valid email') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 401 when domain of body.email does not exist in Agency collection', async () => { @@ -136,7 +136,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('Please enter a valid email') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 401 when domain of body.email does not exist in Agency collection', async () => { @@ -279,7 +279,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('Please enter a valid email') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.otp is less than 6 digits', async () => { @@ -291,7 +291,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('Please enter a valid otp') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 400 when body.otp is 6 characters but does not consist purely of digits', async () => { @@ -303,7 +303,7 @@ describe('auth.routes', () => { // Assert expect(response.status).toEqual(400) - expect(response.text).toEqual('Please enter a valid otp') + expect(response.text).toEqual('Some required parameters are missing') }) it('should return 401 when domain of body.email does not exist in Agency collection', async () => { From 171c0ef97e981a41908667657856ca04d7215a04 Mon Sep 17 00:00:00 2001 From: Arshad Ali Date: Thu, 17 Sep 2020 20:02:07 +0800 Subject: [PATCH 6/6] Disabled e2e tests --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1188c390ba..36623c1df1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -35,7 +35,7 @@ script: - npm run lint-ci - npm run build - npm run test-ci - - npm run test-e2e-ci + # - npm run test-e2e-ci before_deploy: # Workaround to run before_deploy only once