Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use convict.js and type-checking for configuration management #92

Closed
liangyuanruo opened this issue Aug 5, 2020 · 2 comments · Fixed by #190
Closed

Use convict.js and type-checking for configuration management #92

liangyuanruo opened this issue Aug 5, 2020 · 2 comments · Fixed by #190
Assignees
@arshadali172
Labels
P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

It is easy to make mistakes with configuration in the current codebase e.g. CSP headers.

Migrate config.ts to use Convict and its validation features for configuration management.

Additionally, explore whether configuration code can rely on TypeScript enums or String literal types so that the compiler will be able to type-check whether an incorrect value potentially results from a bug in this file.
@liangyuanruo liangyuanruo added the P2 planned for next 1-2 months label Aug 5, 2020
@liangyuanruo liangyuanruo changed the title Use convict.js for configuration management Use convict.js and type-checking for configuration management Aug 5, 2020
@arshadali172 arshadali172 self-assigned this Aug 5, 2020
@arshadali172 arshadali172 mentioned this issue Aug 21, 2020
Merged
3 tasks
@liangyuanruo
Copy link
Contributor Author

Reopened due to #285

@liangyuanruo liangyuanruo reopened this Sep 6, 2020
@arshadali172
Copy link
Contributor

closed by #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arshadali172 arshadali172

Labels
P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use convict for configuration opengovsg/FormSG
2 participants
@liangyuanruo @arshadali172