Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate what is hampering Mongoose library upgrades #506

Closed
liangyuanruo opened this issue Oct 22, 2020 · 1 comment · Fixed by #513
Closed

Investigate what is hampering Mongoose library upgrades #506

liangyuanruo opened this issue Oct 22, 2020 · 1 comment · Fixed by #513
Assignees
@karrui
Labels
bug Something isn't working P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

Server fails to start if mongoose is upgraded:

[2] (node:51992) UnhandledPromiseRejectionWarning: Error: Connection strategy not found
[2]     at new MongoStore (FormSG/node_modules/connect-mongo/src/index.js:127:15)
[2]     at Object.sessionMiddlewares [as default] (FormSG/dist/backend/loaders/express/session.js:20:16)
[2]     at FormSG/dist/backend/loaders/express/index.js:103:30

Related: #394, #504
@liangyuanruo liangyuanruo added bug Something isn't working P2 planned for next 1-2 months labels Oct 22, 2020
@karrui
Copy link
Contributor

karrui commented Oct 26, 2020

It's a bug introduced in 5.10.0, see Automattic/mongoose#9496.

This has been fixed in 5.10.10 via Automattic/mongoose#9497, I'm opening a new PR to fix it since dependabot won't trigger due to the pinning.

@karrui karrui self-assigned this Oct 26, 2020
@karrui karrui mentioned this issue Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karrui karrui

Labels
bug Something isn't working P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): unpin and bump mongoose from 5.10.0 to 5.10.10 opengovsg/FormSG
2 participants
@liangyuanruo @karrui