Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create endpoint for Twilio webhooks #3103

Closed
karrui opened this issue Nov 26, 2021 · 3 comments · Fixed by #3110
Closed

Create endpoint for Twilio webhooks #3103

karrui opened this issue Nov 26, 2021 · 3 comments · Fixed by #3110
Assignees
@zatkiller
Labels
P1 highest priority - pick up as soon as available

Comments

@karrui
Copy link
Contributor

karrui commented Nov 26, 2021

We currently catch the errors Twilio returns on creation of sms, but we do not have a way to catch errors when Twilio fails to send some SMSes.

We should expose an API Twilio can use to ping our servers on errors.

See https://www.twilio.com/docs/usage/webhooks
@karrui karrui added the P1 highest priority - pick up as soon as available label Nov 26, 2021
@karrui
Copy link
Contributor Author

karrui commented Nov 26, 2021

Dylan don't panic, I'll update you on Monday :P

@zatkiller
Copy link
Contributor

@karrui sure

@mantariksh
Copy link
Contributor

bear in mind that this endpoint would receive a very high amount of traffic - Twilio sends 3-4 webhooks for each SMS sent, often within a few seconds of the createMessage request

@zatkiller zatkiller mentioned this issue Nov 29, 2021
Merged
@zatkiller zatkiller mentioned this issue Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zatkiller zatkiller

Labels
P1 highest priority - pick up as soon as available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add twilio webhook endpoint for failed SMS deliveries opengovsg/FormSG
3 participants
@karrui @mantariksh @zatkiller