Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message on sign-in page is broken #2250

Closed
mantariksh opened this issue Jun 24, 2021 · 1 comment · Fixed by #2321
Closed

Error message on sign-in page is broken #2250

mantariksh opened this issue Jun 24, 2021 · 1 comment · Fixed by #2321
Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months

Comments

@mantariksh
Copy link
Contributor

mantariksh commented Jun 24, 2021 •
edited
Loading

Credit to @waynetee for finding this.

To replicate, request for OTP with a non-valid email domain (e.g. "open.gov.rg").

Screenshot 2021-06-24 at 6 11 08 PM
@r00dgirl r00dgirl added easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months labels Jul 1, 2021
@aniruddha-adhikary aniruddha-adhikary mentioned this issue Jul 7, 2021
Merged
2 tasks
@aniruddha-adhikary
Copy link
Contributor

#2321 fixes this!

@seaerchin seaerchin mentioned this issue Aug 2, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: read email validation error message from Joi response aniruddha-adhikary/FormSG
3 participants
@aniruddha-adhikary @mantariksh @r00dgirl