Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated form.permissionsList.read key #2177

Closed
karrui opened this issue Jun 15, 2021 · 2 comments · Fixed by #2197
Closed

Remove deprecated form.permissionsList.read key #2177

karrui opened this issue Jun 15, 2021 · 2 comments · Fixed by #2197
Assignees
@karrui @r00dgirl
Labels
P1 highest priority - pick up as soon as available

Comments

@karrui
Copy link
Contributor

karrui commented Jun 15, 2021

Old forms (created before March 2020) has a form.permissionsList.read key, but Joi validation is blocking this due to new schema shape. This deprecated key should be removed from the collection so Joi validation can be made stricter (again)
@karrui karrui mentioned this issue Jun 16, 2021
Merged
2 tasks
@r00dgirl r00dgirl added easy possible issues that beginners can pick up to get acquainted with the codebase P1 highest priority - pick up as soon as available labels Jun 17, 2021
@r00dgirl
Copy link
Contributor

@karrui can close if no outstanding tasks?

@r00dgirl r00dgirl removed the easy possible issues that beginners can pick up to get acquainted with the codebase label Jun 17, 2021
@karrui
Copy link
Contributor Author

karrui commented Jun 17, 2021

we need to revert the loosening validation hotfix first before this can be closed. i will open a PR for that

@karrui karrui mentioned this issue Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karrui karrui

@r00dgirl r00dgirl

Labels
P1 highest priority - pick up as soon as available
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(AdminFormCtl): remove read permissionList.read key from Joi opengovsg/FormSG
2 participants
@karrui @r00dgirl