Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove endPage.buttons key from old form documents in the database #1895

Closed
karrui opened this issue May 17, 2021 · 0 comments · Fixed by #2087
Closed

Remove endPage.buttons key from old form documents in the database #1895

karrui opened this issue May 17, 2021 · 0 comments · Fixed by #2087
Assignees
@chowyiyin
Labels
P2 planned for next 1-2 months reliability tech debt

Comments

@karrui
Copy link
Contributor

karrui commented May 17, 2021

The endPage.buttons key-values are still in some old form documents. Since it is a deprecated key and preventing us from having stricter Joi validation in AdminFormController#handleUpdateEndPage, we should write a migration script to remove it from the database.
@r00dgirl r00dgirl added easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months labels Jun 3, 2021
@liangyuanruo liangyuanruo added reliability tech debt and removed P2 planned for next 1-2 months easy possible issues that beginners can pick up to get acquainted with the codebase labels Jun 3, 2021
@r00dgirl r00dgirl added the P2 planned for next 1-2 months label Jun 3, 2021
@r00dgirl r00dgirl mentioned this issue Jun 3, 2021
Closed
@chowyiyin chowyiyin self-assigned this Jun 3, 2021
@chowyiyin chowyiyin mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chowyiyin chowyiyin

Labels
P2 planned for next 1-2 months reliability tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove endPage.buttons key from database opengovsg/FormSG
4 participants
@liangyuanruo @karrui @chowyiyin @r00dgirl