Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Extract update form collaborators endpoint from PUT /:formId/adminform #1491

Closed
karrui opened this issue Mar 30, 2021 · 0 comments · Fixed by #1744
Closed

[API] Extract update form collaborators endpoint from PUT /:formId/adminform #1491

karrui opened this issue Mar 30, 2021 · 0 comments · Fixed by #1744
Assignees
Labels
API API refactor P2 planned for next 1-2 months
Milestone

Comments

@karrui
Copy link
Contributor

karrui commented Mar 30, 2021

As tracked in #815, the current form update endpoint is doing too much.

This issue tracks the creation of a new endpoint just to updating form collaborators. The old endpoint should not be deleted for backwards compatibility (at least for a few weeks after the new endpoint has been released).

This is API-P1 (as with all PUT /:formId/adminform endpoints) as this will affect how subsets are updated in the React rewrite. Each endpoint will also have a more well defined responsibility.

New proposed endpoint

PATCH /api/v3/admin/forms/:formId/collaborators

No need for PUT/POST/DELETE HTTP methods since it is just manipulating form.permissionList array values and collaborators have no identifier to act on

@karrui karrui added the API API refactor label Mar 30, 2021
@liangyuanruo liangyuanruo added this to the API refactor milestone Mar 30, 2021
@karrui karrui added the P2 planned for next 1-2 months label Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API refactor P2 planned for next 1-2 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants