Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UEN field #1273

Closed
r00dgirl opened this issue Mar 3, 2021 · 4 comments · Fixed by #2100
Closed

UEN field #1273

r00dgirl opened this issue Mar 3, 2021 · 4 comments · Fixed by #2100
Labels
contribute free for contributors to pick up P4

Comments

@r00dgirl
Copy link
Contributor

r00dgirl commented Mar 3, 2021

  • Helps to reduce typos in UENs and ensure data accuracy

https://gist.github.com/mervintankw/90d5660c6ab03a83ddf77fa8199a0e52

@r00dgirl r00dgirl added P3 contribute free for contributors to pick up P4 and removed P3 labels Mar 3, 2021
@aniruddha-adhikary
Copy link
Contributor

@syan-syan Is the objective of this ticket to introduce a new Field Type for UENs? Could some more information be provided? I am interested to contribute. 🚀

@mantariksh
Copy link
Contributor

@aniruddha-adhikary That's right! Broadly the implementation will involve:

  1. Adding a new database schema for UEN fields
  2. Adding the UEN field on the admin Build tab so admins can add it to their forms
  3. Adding validation on the frontend to ensure that form-fillers are prevented from submitting invalid UENs via the UI
  4. Adding backend validation to ensure that submitted UEN answers are valid

@aniruddha-adhikary
Copy link
Contributor

@mantariksh thanks for getting back to me on this!

I was wondering if it would be a good idea to merge the NRIC/FIN and UEN fields in a single field. There could be a selector to select whether users could enter NRIC/FIN, UEN or Both. It would make the widgets panel less bloated.

@aniruddha-adhikary
Copy link
Contributor

#2100 should close this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute free for contributors to pick up P4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants