Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Mobile number validation accepts 3xxxxxx, 4xxxxxx, etc. numbers #100

Closed
leonardloo opened this issue Aug 6, 2020 · 1 comment · Fixed by #101
Closed

Bug: Mobile number validation accepts 3xxxxxx, 4xxxxxx, etc. numbers #100

leonardloo opened this issue Aug 6, 2020 · 1 comment · Fixed by #101
Assignees
@karrui
Labels
P2 planned for next 1-2 months

Comments

@leonardloo
Copy link

Mobile numbers in Singapore start with either 8 or 9. While numbers starting with 6 are rejected, oddly enough numbers starting with 1,2,3,4,5,7 are accepted. Don't remember this being there previously. Better to patch this quickly as this means validation isn't really working.
@leonardloo leonardloo added the P2 planned for next 1-2 months label Aug 6, 2020
@karrui
Copy link
Contributor

karrui commented Aug 6, 2020

Remember the bug where mobile field validation was too strong and legit numbers are being rejected? Mobile field validation was then loosened again to only validate against the length....

I guess I can add validation to only accept numbers starting with 8/9s :(

@karrui karrui self-assigned this Aug 6, 2020
@karrui karrui mentioned this issue Aug 6, 2020
Merged
@tshuli tshuli mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karrui karrui

Labels
P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: phone validation now only accepts 8 digit #s starting with 8 or 9 opengovsg/FormSG
2 participants
@leonardloo @karrui