Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复 Dubbo 错误的日志打印 #720

Closed
iwangjie opened this issue Sep 23, 2022 · 2 comments · Fixed by #1018
Closed

修复 Dubbo 错误的日志打印 #720

iwangjie opened this issue Sep 23, 2022 · 2 comments · Fixed by #1018
Labels
good first issue Issues for first-time contributors in: hippo4j-all
Milestone
1.5.0

Comments

@iwangjie
Copy link
Member

image

自 #708 修复以后，该日志打印便不再准确，isLegacyVersion 不再作为 dubbo 2 和 dubbo 3 的判断依据，应该使用当前 dubbo 具体版本号。
@magestacks magestacks changed the title 修复错误的日志打印 Dubbo修复错误的日志打印 Oct 3, 2022
@magestacks magestacks changed the title Dubbo修复错误的日志打印 修复 Dubbo 错误的日志打印 Oct 3, 2022
@baymax55
Copy link
Contributor

如何修复呢，在日志中打印当前版本的Dubbo具体版本号吗，Dubbo是否提供接口获取当前版本号呢

@iwangjie
Copy link
Member Author

如何修复呢，在日志中打印当前版本的Dubbo具体版本号吗，Dubbo是否提供接口获取当前版本号呢

参考 Version.getVersion

@baymax55 baymax55 mentioned this issue Nov 27, 2022
Merged
@magestacks magestacks added this to the 1.5.0 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues for first-time contributors in: hippo4j-all
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Print the current dubbo version number baymax55/hippo4j
3 participants
@iwangjie @baymax55 @magestacks