Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPL: Adding height info of '17m' (from local attributes.json file) #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rt17603
Copy link
Contributor

@rt17603 rt17603 commented Jan 9, 2023

Current "height" for NPL (LGHG inlet at National Physical Laboratory) is listed as "NA" within the site_info.json file.

When processing in OpenGHG at the moment this is using a value from the locally stored attributes.json file instead which lists the inlet as "17m" rather than "NA". (This information may have originally been supplied by Daniel Hoare).

Adding the "17m" to the site_info.json to ensure all inlet information is retrieved from one place.

@rt17603 rt17603 requested a review from ag12733 May 4, 2023 17:09
@rt17603 rt17603 requested review from ag12733 and removed request for ag12733 June 12, 2023 08:35
@ag12733
Copy link
Contributor

ag12733 commented Jun 17, 2023

This looks fine to me. There is a new field in here called 'status' and it is set to current. Is this something that should be rolled out broadly? Also is this current as it is under the LGHG project.

@rt17603
Copy link
Contributor Author

rt17603 commented Jun 29, 2023

This looks fine to me. There is a new field in here called 'status' and it is set to current. Is this something that should be rolled out broadly? Also is this current as it is under the LGHG project.

Good question - it may be that we don't need this in our site_info.json anymore - who would know do you think if it would be worth including this?

@ag12733
Copy link
Contributor

ag12733 commented Jul 5, 2023

@mrghg Do we need an entry called 'status' in the json. It is another thing to have to keep updating...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants