Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is parameter-names mandatory or optional? #370

Closed
ghobona opened this issue May 10, 2022 · 1 comment
Closed

Is parameter-names mandatory or optional? #370

ghobona opened this issue May 10, 2022 · 1 comment
Labels
2022-05 Sprint API EDR V1.0.1 Correction or editorial change for Version 1.0.1

Comments

@ghobona
Copy link
Contributor

ghobona commented May 10, 2022

collection.yaml declares:

type: object
required:
  - links
  - id
  - extent
  - parameter-names

However, Step 6 of Abstract Test 14 says "Verify that if the collection entry includes an parameter-names property, the property complies with /req/edr/rc-parameters".

The use of the word 'if' implies that parameter-names is optional.

Recommended actions:

  1. Update the text or the yaml file to clarify whether parameter-names is optional or not.
  2. Fix the typo "an parameter-names property" should be "a parameter-names property"

NOTE: The presence of a parameter-names or parameter_names property is currently (at v1.0.0) the only way to determine whether a collection is an EDR collection or not. So the property is very helpful.

@chris-little
Copy link
Contributor

Already Merged. Agreed to close at EDR API SWG76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2022-05 Sprint API EDR V1.0.1 Correction or editorial change for Version 1.0.1
Projects
None yet
Development

No branches or pull requests

2 participants