Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did you drop leafmap.connect_postgis?? #989

Closed
glemoine62 opened this issue Nov 19, 2024 · 2 comments
Closed

Did you drop leafmap.connect_postgis?? #989

glemoine62 opened this issue Nov 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@glemoine62
Copy link

Environment Information

  • leafmap version: 0.40.1
  • Python version: 3.12.3
  • Operating System: Ubuntu 24.04.1

Description

I did a fresh install of leafmap this morning and discovered that leafmap.connect_postgis is no longer working. Did you drop it?
I see that there is now common.read_postgis (instead?).

What I Did

python3 -c 'import leafmap; print(dir(leafmap))' | grep connect_postgis

(returns nothing)

@glemoine62 glemoine62 added the bug Something isn't working label Nov 19, 2024
@glemoine62
Copy link
Author

glemoine62 commented Nov 19, 2024

Aha, now leafmap.common.connect_postgis():

python3 -c 'from leafmap import common; print(dir(common))' | grep connect_postgis

@giswqs
Copy link
Member

giswqs commented Nov 20, 2024

Correct. The * import of the common module has been remvoed. See #980
You can use from leafmap.common import connect_postgis

@giswqs giswqs closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants