Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly release now doesn't include example files for Visual Studio #7856

Closed
ofTheo opened this issue Jan 7, 2024 · 4 comments
Closed

nightly release now doesn't include example files for Visual Studio #7856

ofTheo opened this issue Jan 7, 2024 · 4 comments

Comments

@ofTheo
Copy link
Member

ofTheo commented Jan 7, 2024

Just tested a nightly and while there are VS Code project files there are no Visual Studio files ( for the examples )

@ofTheo
Copy link
Member Author

ofTheo commented Jan 10, 2024

Okay from testing locally this seems to be due to adding the vscode template to the generate all examples.

running:
apps/projectGenerator/commandLine/bin/projectGenerator_debug --recursive -pvs -tvscode

doesn't work

running:
apps/projectGenerator/commandLine/bin/projectGenerator_debug --recursive -pvs,vscode

does work

I think this is due to:
openframeworks/projectGenerator@9a138d4

Going to switch the nightly builds to use the comma separated approach and fix the PG separately.

@dimitre
Copy link
Member

dimitre commented Jan 10, 2024

I've noticed the same for XCode projects, osx is packaging with only vscode.
I was wondering about create_package.sh

        #add vscode to all platforms apart from ios/tvos/android
        if [ "$pkg_platform" == "android" ] || [ "$pkg_platform" == "ios" ]; then
            pg_template=" "
        else
            pg_template="-tvscode"
        fi

@ofTheo
Copy link
Member Author

ofTheo commented Jan 10, 2024

yeah just realized Xcode too as well!
going to switch it to use the non template approach in create_package and then fix it properly in PG

@ofTheo ofTheo closed this as completed in 42ab115 Jan 10, 2024
@ofTheo
Copy link
Member Author

ofTheo commented Jan 10, 2024

okay this is fixed now and current nightly should be good - phew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants