Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SepalMap takes too much time to init #791

Open
12rambau opened this issue Mar 15, 2023 · 4 comments
Open

SepalMap takes too much time to init #791

12rambau opened this issue Mar 15, 2023 · 4 comments

Comments

@12rambau
Copy link
Member

12rambau commented Mar 15, 2023

I checked on my computer a normal ipyleaflet map takes 5s to start, a SepalMap consume a good 50s i.e. 10x more time.

I think it's related to the differnet widget we init with the map iteslf (drawing control, fullscreencontrol, etc...) this take lots of resources and even more if the end developer is not using them. I think we should work on 2 things:

  • reduce the computation burden of the layersControl
  • init virgin SepalMap and let the developers add what they need
@12rambau
Copy link
Member Author

@dfguerrerom di you start your map with buitl-in widgets or do you use virgin map and add them manually ?

@dfguerrerom
Copy link
Collaborator

What types of controls do you refer to? if are the basic ones such as ZoomControl, LayersControl or ScaleControl, yes I don't want to add them manually, I think the initialization of our SepalMap is functional and minimal.

@12rambau
Copy link
Member Author

I was effectively thinking abut them, if you look at ipyleaflet, it starts completely virgin from any controls. The only default ones are copyrights and zoom levels.

@dfguerrerom
Copy link
Collaborator

I see more use cases where you at least have those defaults + LayerControl, I don't have too many examples in my mind where you only need the zoom levels and copyrights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants