Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor add_layer and remove_layer #626

Open
12rambau opened this issue Nov 25, 2022 · 0 comments
Open

refactor add_layer and remove_layer #626

12rambau opened this issue Nov 25, 2022 · 0 comments
Labels
cd/ci relative to CI needs discussion needs discussion

Comments

@12rambau
Copy link
Member

In the latest release of ipyleaflet, all components (controls, layers etc...) are added to the map using add instead of add_layer and add_control.

In the lib we are overwriting the add_layer in multiple ways. The implementation does not rise DeprecationWarning anymore but we should consider refactoring the way we add layers to the map so that newcomers don't get lost.

@12rambau 12rambau added cd/ci relative to CI needs discussion needs discussion labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd/ci relative to CI needs discussion needs discussion
Projects
None yet
Development

No branches or pull requests

1 participant