migration steps reset: fix double insert #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorja
commented
Nov 8, 2024
minotogna
reviewed
Nov 8, 2024
minotogna
approved these changes
Nov 8, 2024
mergify bot
added a commit
that referenced
this pull request
Nov 8, 2024
* Migration-steps: Reset * migration steps reset: fix double insert (#4097) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Miró Sorja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
main file (index.ts):
ignore files ending -step-reset (dont double insert the row in db
steps)reset template and existing reset step:
use
pathand__filenameto get current file namereset.ts (yarn migration-steps:reset):
dont autorun the reset step - should we ? @minotogna
this requires to run
migration-steps:runafter resettingi think this approach is more failsafe (requires user to run the migration steps that would be run on other instances, eg review, other developer, prod..)