Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split User Role / Invitation #4032

Open
16 of 25 tasks
minotogna opened this issue Oct 16, 2024 · 1 comment · May be fixed by #4053
Open
16 of 25 tasks

Split User Role / Invitation #4032

minotogna opened this issue Oct 16, 2024 · 1 comment · May be fixed by #4053
Assignees
Labels
discussion It requires a discussion before implementation enhancement New feature or request refactor Code quality improvement
Milestone

Comments

@minotogna
Copy link
Member

minotogna commented Oct 16, 2024

Where necessary, add relevant comments in the user invitation flow

  • Split db, types and datamigration
  • Country collaborators page: split collaborators and invitations tables (2 tables, add plus button on top of invitations table)
  • Update country status change confirm pop up
  • Remove deprecated component: componentsUserList
  • Verify user invitation process (check API/Controller/Repository)
  • Verify admin invitation page
  • View
  • Verify admin collaborators page (invitation are also included in the users list)
  • Verify introduction contact user list
  • Country summary materialized : Invitations count
  • Country Home Page update to single list
  • Verify edit user (and user role props) works
    • Test editing collaborator with admin
    • Test inviting new collaborator, accepting invitation and update information after redirect, after Edit profile
  • Update UI as in given layout (Slack)
  • Admin add or remove multiple roles
  • Add user download buttons (country home / collaborators) (separate PR)

  • Setup E2E testing

    • Init DB:
      • Controller OUTPUT: Metadata and data for all countries 2020 and 2025
      • Controller INPUT
  • Test cases

    • Test: user login (admin)
    • Test: User invite (admin invite all roles, all combinations) (Verify working from admin page invitations)
    • Test: User accept invitation with login

@minotogna minotogna added enhancement New feature or request refactor Code quality improvement discussion It requires a discussion before implementation labels Oct 16, 2024
@minotogna minotogna modified the milestones: 3.8.0, 3.7.0 Oct 16, 2024
@sorja sorja self-assigned this Oct 16, 2024
@sorja sorja linked a pull request Oct 23, 2024 that will close this issue
6 tasks
@sorja
Copy link
Contributor

sorja commented Nov 7, 2024

Let's update:

  • Country collaborators:
    • Single list with mixed users and invitations (pending users)
  • Admin manage collaborators

New view:

country_user_summary

columns:

name
surname
fullname?:
country_iso
role: the role for the given country_iso | nullable
invitation: the invitation for given country (admin page> text disabled -> something noting: pending invitation)

either is active

Type:

type CounrtyUserSummary = {

}

Server


CountryUserRepository.{}

@minotogna minotogna linked a pull request Dec 13, 2024 that will close this issue
6 tasks
@minotogna minotogna self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion It requires a discussion before implementation enhancement New feature or request refactor Code quality improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants