Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QCSubmit discussion on necessity of InChI and other keys #426

Open
lilyminium opened this issue Feb 4, 2025 · 1 comment
Open

QCSubmit discussion on necessity of InChI and other keys #426

lilyminium opened this issue Feb 4, 2025 · 1 comment

Comments

@lilyminium
Copy link
Contributor

lilyminium commented Feb 4, 2025

Probably will happen in a QCSubmit meeting.

@j-wags
Copy link
Member

j-wags commented Feb 6, 2025

We discussed this and I'm fine with the TM datasets going in without InChIs, and really only with the maximal CMILES (AFAIK, nobody on earth has used anything other that the maximal CMILES anyway, and the other identifiers can be derived from it if we need them later). It should be accompanied by a PR to QCADS, but if there's any trouble at all with ingesting the dataset.json, that should be left out and the dataset should be submitted directly using QCPortal (though the PR should go in as a record with the PDF of the structures and such).

@j-wags j-wags transferred this issue from openforcefield/openff-toolkit Feb 6, 2025
@openforcefield openforcefield deleted a comment from lilyminium Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants