You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some subscription specs, we were making the wrong assertions but the specs were still passing. This was because generated addresses have the same attributes by default, and this was affecting some logic.
The POC PR openfoodfoundation/openfoodnetwork#3637 shows that randomizing addresses for subscription bill and ship addresses by default do not affect specs other than those addressed for OrderSyncer. What happens when randomizing all addresses by default?
What we should change and why (this is tech debt)
In some subscription specs, we were making the wrong assertions but the specs were still passing. This was because generated addresses have the same attributes by default, and this was affecting some logic.
The POC PR openfoodfoundation/openfoodnetwork#3637 shows that randomizing addresses for subscription bill and ship addresses by default do not affect specs other than those addressed for
OrderSyncer
. What happens when randomizing all addresses by default?Context
This came up in PR openfoodfoundation/openfoodnetwork#3605.
Impact and timeline
The text was updated successfully, but these errors were encountered: