Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subscriptions] Randomize generated addresses for specs #362

Open
Tracked by #353
kristinalim opened this issue Mar 21, 2019 · 0 comments
Open
Tracked by #353

[Subscriptions] Randomize generated addresses for specs #362

kristinalim opened this issue Mar 21, 2019 · 0 comments

Comments

@kristinalim
Copy link
Member

kristinalim commented Mar 21, 2019

What we should change and why (this is tech debt)

In some subscription specs, we were making the wrong assertions but the specs were still passing. This was because generated addresses have the same attributes by default, and this was affecting some logic.

The POC PR openfoodfoundation/openfoodnetwork#3637 shows that randomizing addresses for subscription bill and ship addresses by default do not affect specs other than those addressed for OrderSyncer. What happens when randomizing all addresses by default?

Context

This came up in PR openfoodfoundation/openfoodnetwork#3605.

Impact and timeline

@sigmundpetersen sigmundpetersen changed the title Randomize generated addresses for specs [Subscriptions] Randomize generated addresses for specs Feb 10, 2020
@lin-d-hop lin-d-hop transferred this issue from openfoodfoundation/openfoodnetwork Nov 18, 2022
@RachL RachL added the Parked label Feb 28, 2024
@github-project-automation github-project-automation bot moved this to Candidates in Wishlist Board Feb 28, 2024
@RachL RachL moved this from Candidates to Stuff from main repo for review in Wishlist Board Feb 28, 2024
@RachL RachL removed the Parked label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Stuff from main repo for review
Development

No branches or pull requests

2 participants