Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Fee Summary] Explore refactoring the SQL in Scope #352

Open
Tracked by #337
kristinalim opened this issue Dec 14, 2018 · 0 comments
Open
Tracked by #337

[Enterprise Fee Summary] Explore refactoring the SQL in Scope #352

kristinalim opened this issue Dec 14, 2018 · 0 comments
Labels
tech debt

Comments

@kristinalim
Copy link
Member

Explore refactoring the SQL in Scope.

Description

Explore refactoring some SQL statements in the Scope class. Are there places where we can use existing associations? Can we use Arel here?

See this review thread.

Expected Behavior

No user-observable changes expected.

Actual Behavior

No user-observable changes expected.

Context

Follow-up changes for openfoodfoundation/openfoodnetwork#3115

Severity

Not a bug
@kristinalim kristinalim mentioned this issue Dec 14, 2018
Merged
@kristinalim kristinalim mentioned this issue Feb 1, 2019
Merged
@lin-d-hop lin-d-hop transferred this issue from openfoodfoundation/openfoodnetwork Nov 18, 2022
@sigmundpetersen sigmundpetersen mentioned this issue Feb 21, 2024
Open
15 tasks
@RachL RachL added the Parked label Feb 28, 2024
@github-project-automation github-project-automation bot moved this to Candidates in Wishlist Board Feb 28, 2024
@RachL RachL moved this from Candidates to Stuff from main repo for review in Wishlist Board Feb 28, 2024
@RachL RachL removed the Parked label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Wishlist Board
Status: Stuff from main repo for review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kristinalim @RachL