-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer I18n translations used by the JS to the "js." namespace #342
Comments
@dacook as you dive into translation recently, do you know if this issue is still needed? We are doing a bit of clean up with Lynne :) 🧹 |
Hi @RachL , I dove into the discussion and yes, this looks like it is still relevant. It's a pre-requisite for an issue to reduce the initial page download size and browser memory use (openfoodfoundation/openfoodnetwork#2722). It looks like Zenhub isn't set up for this repo so I can't add it as a pre-requisite. It was discussed and agreed by Kristina, Luis and Maikel in 2018. Since then, the translations have grown so I've re-estimated the gain, which has grown since then. I added these details in the issue description. I've not looked into the code yet to estimate how much work is needed though. I think it would take me a while to find my way around, and I suspect JB could estimate this much quicker than me. |
Preliminary work to reduce the speed and browser memory usage when loading the website
Description
This was discussed here.
Before transferring a translation key, make sure that there are no other parts of the website using the translation. Otherwise, keep the old translation and just add a new one under "js.".
Expected Behavior
All translation keys used in the JS are under the "js." namespace.
Actual Behavior
Not all translation keys used in the JS are under the "js." namespace.
The text was updated successfully, but these errors were encountered: