Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer I18n translations used by the JS to the "js." namespace #342

Open
Tracked by #337
kristinalim opened this issue Sep 13, 2018 · 2 comments
Open
Tracked by #337

Comments

@kristinalim
Copy link
Member

Preliminary work to reduce the speed and browser memory usage when loading the website

Description

This was discussed here.

Before transferring a translation key, make sure that there are no other parts of the website using the translation. Otherwise, keep the old translation and just add a new one under "js.".

Expected Behavior

All translation keys used in the JS are under the "js." namespace.

Actual Behavior

Not all translation keys used in the JS are under the "js." namespace.

@RachL
Copy link
Contributor

RachL commented Nov 18, 2022

@dacook as you dive into translation recently, do you know if this issue is still needed? We are doing a bit of clean up with Lynne :) 🧹

@lin-d-hop lin-d-hop transferred this issue from openfoodfoundation/openfoodnetwork Nov 18, 2022
@dacook
Copy link
Member

dacook commented Nov 21, 2022

Hi @RachL , I dove into the discussion and yes, this looks like it is still relevant. It's a pre-requisite for an issue to reduce the initial page download size and browser memory use (openfoodfoundation/openfoodnetwork#2722). It looks like Zenhub isn't set up for this repo so I can't add it as a pre-requisite.

It was discussed and agreed by Kristina, Luis and Maikel in 2018. Since then, the translations have grown so I've re-estimated the gain, which has grown since then. I added these details in the issue description.

I've not looked into the code yet to estimate how much work is needed though. I think it would take me a while to find my way around, and I suspect JB could estimate this much quicker than me.

@RachL RachL added the Parked label Feb 28, 2024
@github-project-automation github-project-automation bot moved this to Candidates in Wishlist Board Feb 28, 2024
@RachL RachL moved this from Candidates to Stuff from main repo for review in Wishlist Board Feb 28, 2024
@RachL RachL removed the Parked label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Stuff from main repo for review
Development

No branches or pull requests

3 participants