Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Show error message when trying to delete an active shipping method #9613

Closed
audez opened this issue Aug 31, 2022 · 1 comment
Closed
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. feedback-needed

Comments

@audez
Copy link
Collaborator

audez commented Aug 31, 2022

Description

On the shipping method list page (admin/shipping_methods), you can delete an active shipping method. It will disappear from the page as if it was deleted, but in fact it was not.

Expected Behavior

If an active shipping method can't be deleted:
Grey out the Trash icon (and display a message on hover)
or
Show an error message when clicking on the trash icon to delete the method, for ex "You can't delete an active shipping method. Please first disable this method in your enterprise setting."

Actual Behaviour

You can click on the trash to delete an active shipping method. The method will disappear from the page and user thinks it was deleted, but it was not. It still appears as an active method in the Enterprise settings.

Steps to Reproduce

  1. Go to Enteprise > Settings > Shipping methods
  2. Activate two shipping methods
  3. Click on "Edit" on one of the shipping methods, then "Back to shipping method list"
  4. Click on the trash for one of the active shipping methods. It will be deleted from the list.
  5. Refresh the page and see it again.

Animated Gif/Screenshot

1 - "tet" is an active method. I can delete it

Screen Shot 2022-08-31 at 14 44 41

2 - it is removed from the list without error

Screen Shot 2022-08-31 at 14 44 55

3 - after refreshing the page, it appears again

Screen Shot 2022-08-31 at 14 45 01

Workaround

Disable the shipping method in your enterprise setting before deleting it.

Severity

bug-s4: it's annoying, but you can use it

@audez audez added feedback-needed bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. labels Aug 31, 2022
@audez audez changed the title [Admin] Show error message when trying to delete an active payment method [Admin] Show error message when trying to delete an active shipping method Aug 31, 2022
@audez
Copy link
Collaborator Author

audez commented Aug 31, 2022

Actually it applies only if the shipment method has been used in an order so it's a duplicate of #6135

@audez audez closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s4 The bug is annoying, but doesn't prevent from using the platform. Not so many users are impacted. feedback-needed
Projects
None yet
Development

No branches or pull requests

1 participant