[Reports] Disable "Header row" option for .csv exports

[audez]

Description

In Reports, the option "header row" should be disabled for .csv exports.

Expected Behavior

In the reports the "header row" checkbox should be greyed out, as it is not possible to display the header row in csv files.
The behavior should be similar to the "Summary row" option (see #9291 ).

This applies to all the reports that have the "display: header row / summary row" option:

• Bulk Co-Op
• Orders & Fulfillment Reports
• Packing Reports
• Packing

Actual Behaviour

The "header row" checkbox is not disabled and can be checked, but this has no effect on the export file.

Steps to Reproduce

1. Go to Reports > Packing reports (/admin/reports/packing) - or any other report listed above
2. In " Generate report " choose "csv"

Animated Gif/Screenshot

Severity

bug-s3: a feature is broken but there is a workaround

[jibees]

Sorry, but I think it's a duplicate from #9291 (which should be edited I think)

[RachL]

@jibees as there is already a PR attached, I was too lazy to update it :)

[RachL]

This was apparently working well before a recent release, but I can't find the related issue.

@audez FYI header row were never included in .csv. Total rows were, perhaps they were referring to that? In any case, I'm surprised they like .csv : do you know why they use this format? We are not going to add any formatting to .csv form anymore, it will stay a "raw" version. The .xlsx version is the one with the shiny stuff :D So I'm wondering what's blocking them to use the spreadsheet version? 🤔

[audez]

Thanks guys! And sorry for the duplicate, my issue searching skills really needs improvement 😳
I thought the total rows were there in the csv, so i figured he was talking about the summary rows. But yes you're right, as I see now, there's no total row in the csv neither, and that was the problem. I just called him and he said he used csv because he didn't see the others, but now it's fine he will use the shiny Excel ✨

[RachL]

cooool :) Nice one @audez 💪 And again don't worry about duplicates ;)

[filipefurtad0]

I think we might need to re-open this one as #9563 only affects the summary row, and not the header row?

[audez]

Yeah actually the header row was only mentioned in the comments in #9291 . As far as I understand, both checkboxes should be disabled as CSV is just a raw version. Do you think I could change this issue to "grey out the header row option", and reopen it, or is it better to create a new issue?
Too bad as it could have been done at once 😬

[filipefurtad0]

Thanks @audez, I'd say updating and reopening would be fine 👍