Embedding group page with invalid URL raises error

[mkllnk]

Description

The groups page is checking the browser supplied referer header but expects it to be a valid URI. Apparently, sometimes it's not valid and then the page is inaccessible.

Expected Behavior

The page still shows.

Actual Behaviour

A snail is shown.

Steps to Reproduce

I was unable to reproduce this because my browsers (Firefox and Chrome) corrected the URL automatically.

Animated Gif/Screenshot

Workaround

Link to the group page with the correct link.

Severity

bug-s5: we can live with it, only a few users impacted

Your Environment

• Version used: v4.2.0
• Browser name and version:
• Operating System and version (desktop or mobile):

Possible Fix

At a rescue statement:

openfoodnetwork/app/services/embedded_page_service.rb

Lines 70 to 77 in 6a80cb8

	def current_referer
	return if @request.referer.blank?
	uri = URI(@request.referer)
	return if uri.host.blank?
	uri.host.downcase
	end

Error in OpenFoodNetwork Aus

URI::InvalidURIError in groups#show
bad URI(is not URI?): "https://www.openfoodnetwork.org.au/groups/6##hubs"

View on Bugsnag

Stacktrace

app/services/embedded_page_service.rb:73 - current_referer
app/services/embedded_page_service.rb:29 - embeddable?
app/services/embedded_page_service.rb:19 - embed!
app/controllers/concerns/embedded_pages.rb:25 - embed_service
app/controllers/concerns/embedded_pages.rb:17 - enable_embedded_pages
lib/session_cookie_upgrader.rb:19 - call

View full stacktrace

Created by Maikel via Bugsnag