Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments breaking due to unmet dependencies #9250

Closed
filipefurtad0 opened this issue Jun 1, 2022 · 5 comments · Fixed by #9253
Closed

Deployments breaking due to unmet dependencies #9250

filipefurtad0 opened this issue Jun 1, 2022 · 5 comments · Fixed by #9253
Assignees

Comments

@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Jun 1, 2022

Description

We currently have some unmet dependencies on master (could be related to #9243 #9244 #9245).

This can be seen after pulling the latest master and running bundle install && yarn install, below the output:
EDIT: These are just warnings and don't break the deployment. See below

warning " > [email protected]" has unmet peer dependency "@babel/core@^7.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/addons > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/addons > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-controls > @storybook/components > [email protected]" has unmet peer dependency "react@>= 0.14.0".
warning "@storybook/addon-docs > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "@storybook/addon-docs > @mdx-js/[email protected]" has unmet peer dependency "react@^16.13.1 || ^17.0.0".
warning "@storybook/addon-docs > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".

We can also see the errors appearing on the deployment log:
"Error: Cannot find module '@babel/plugin-proposal-private-property-in-object", on semaphore:
https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/servers/uk-staging/deploys/1233

@filipefurtad0 filipefurtad0 changed the title Unmet dependencies on master branch Deployments breaking due to unmet dependencies Jun 1, 2022
@jibees
Copy link
Contributor

jibees commented Jun 2, 2022

If I'm not mistaken, its here since when we introduced storybook (and maybe before).
What came in my mind was maybe to remove all those 3 dependencies, as we basically don't use it...

@jibees
Copy link
Contributor

jibees commented Jun 2, 2022

(finally found it ; it's something around babel... ;))

@filipefurtad0
Copy link
Contributor Author

Ok, thanks for addressing this @jibees - apologies if my lead was misleading in the description.

@sigmundpetersen
Copy link
Contributor

Ok, thanks for addressing this @jibees - apologies if my lead was misleading in the description.

And apologies if I misled you in the first place @filipefurtad0 🙂

@jibees
Copy link
Contributor

jibees commented Jun 2, 2022

6ibpli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants